Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-normalize line-endings in git of all files to Linux style ("\n") #954

Merged

Conversation

HannesWell
Copy link
Contributor

What it does

Some files were checked-in into git having windows style line endings (\r\n). This is in general not wanted because it can cause modified files without any difference in git-staging on Windows if auto-crlf is enabled.

To re-normalize line endings of all files use the following command (including dot):

git add --renormalize .

This is the same as eclipse-jdt/eclipse.jdt.core#1644, just for this repository.

Most files are not productive files, only some source files of the relatively new bytecode-view are affected.
@iloveeclipse do you want to have a look at this one?

Author checklist

Some files were checked-in into git having windows style line
endings (\r\n). This is in general not wanted because it can cause
modified files without any difference in git-staging on Windows if
auto-crlf is enabled.

To re-normalize line endings of all files use the following command
(including dot):

git add --renormalize .
@iloveeclipse
Copy link
Member

do you want to have a look at this one?

LGTM

@iloveeclipse
Copy link
Member

Not sure if there versions need to be bumped, please check in the IDE.

@HannesWell
Copy link
Contributor Author

Not sure if there versions need to be bumped, please check in the IDE.

Checked it. All affected projects have already been bumped within the last two days thanks to Jörgs Java-doc fixings.

@iloveeclipse iloveeclipse merged commit 66a27ce into eclipse-jdt:master Nov 30, 2023
7 checks passed
@iloveeclipse
Copy link
Member

Thanks

@HannesWell HannesWell deleted the renormalize-line-endings branch November 30, 2023 22:30
@HannesWell
Copy link
Contributor Author

Thanks for submitting so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants