Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to lsp4j 0.7.x #1040

Closed
fbricon opened this issue May 15, 2019 · 7 comments · Fixed by #1082
Closed

Migrate to lsp4j 0.7.x #1040

fbricon opened this issue May 15, 2019 · 7 comments · Fixed by #1082

Comments

@fbricon
Copy link
Contributor

fbricon commented May 15, 2019

@NikolasKomonen wanna give it a try? now that you're familiar with 0.7.1 ;-)

@fbricon fbricon added this to the End May 2019 milestone May 15, 2019
@NikolasKomonen
Copy link
Contributor

Yeah, sounds good.

lsp4j changelog:
* Setters and constructors of protocol classes throw IllegalArgumentException if given null for properties marked with @NonNull

Hope there wont be many issues with this one :)

@fbricon
Copy link
Contributor Author

fbricon commented May 16, 2019

@NikolasKomonen actually migration to 0.7 should be covered by #925 already. So we can wait for @kittaakos's update of that PR

@kittaakos
Copy link

Hope there wont be many issues with this one :)

Yeah, I do not like this change either. If you find the new behavior inconvenient, please file an issue in LS4J.

So we can wait for @kittaakos's update of that PR

Please note, according to the plans, there will be a 0.7.2 release, so that the textDocument/callHierarchy is in sync with the proposed LSP change.

@fbricon
Copy link
Contributor Author

fbricon commented May 16, 2019

@kittaakos cool. do you have a timeframe for that?

@kittaakos
Copy link

do you have a timeframe for that?

Did you mean wrapping up the call hierarchy implementation? I am a little bit busy with other things, but I will look into the required changes on of the evenings. How urgently would you like to see the textDocument/callHierarchy on the master? :)

@fbricon
Copy link
Contributor Author

fbricon commented May 16, 2019

nothing urgent. Just so I have an idea in which release to target the feature.
I'm just eager to play with it in vscode ;-)

@akaroml
Copy link
Contributor

akaroml commented Jul 1, 2019

@fbricon I tried this one as my first commit :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants