-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jdt.ls 1.9.0 breaks workspace loading #2024
Comments
@jeffmaury could you, please, try the latest snapshot - https://download.eclipse.org/jdtls/snapshots/repository/1.10.0.202203160029/ |
Using https://download.eclipse.org/jdtls/snapshots/repository/1.10.0.202203160029/ .
stacktrace
|
Update : Ok, I think I found the root cause, a workaround, and a potential fix we need. @fbricon @testforstephen , any issue with making the m2e requirements strict (instead of optional) to support Jeff's use case ? |
I don't think this is the cause as I'm installing the EPP Java package which has M2E (so CRS where I discovered the bug). But will test |
@snjeza Got the same error using https://download.eclipse.org/jdtls/snapshots/repository/1.10.0.202203160029/ |
With the Java EPP I see this : stacktrace
The ExceptionInitializationError is a hint that something failed in a static block. Once the that fails, the class never gets loaded. |
I don't get the point why Optional requirement is the cause of the failure. jdt.ls distros contain the required m2e bundles, it should load m2e bundle on demand. The reason that we make m2e and buildship to be an optional dependency is to improve loading speed and memory consumption of the lightweight mode. m2e and buildship are only loaded in standard mode, but not in lightweight mode. |
Yes, the JDT-LS tarball contains all the required dependencies, but we also ship a p2 repo at Eclipse that contains just the org.eclipse.jdt.ls.core bundle ( https://download.eclipse.org/jdtls/snapshots/repository/1.10.0.202203160029/plugins/ ). The more recent stacktrace I posted is something else though, because m2e was there already. |
I'm pretty sure it's related to the Maybe it's as simple as JDT-LS needs to be started automatically now that it contributes tot he filesystem extension point. Even though the filesystem isn't used, it acts as a wrapper for the default behaviour, so it's enough for JDT-LS to fail to load it. @jeffmaury , what's your specific use case for installing JDT-LS into Eclipse ? Is it not easier to use the JDT-LS (self-contained) tarball to run it headless ? |
Close since it's fixed by #2309. Let us know if it's not working. |
I have performed the following actions:
Opened a new workspace: OK
Reopened the workspace: KO, Eclipse does not launch, dialog is shown to look at .log
The text was updated successfully, but these errors were encountered: