Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile merging omits parent field #2174

Closed
manusa opened this issue May 25, 2023 · 0 comments · Fixed by #2175
Closed

Profile merging omits parent field #2174

manusa opened this issue May 25, 2023 · 0 comments · Fixed by #2175
Assignees
@manusa
Labels
bug Something isn't working
Milestone
1.13.0

Comments

@manusa
Copy link
Member

manusa commented May 25, 2023

Description

The Profile merge constructor doesn't take into account the parentProfile field. When merging two profiles, none of the fields is preserved.

This is a specially big issue when merging two identical profiles. This situation happens whenever the classloader contains one or more profiles-default.yml resources which can happen when using both plugins (e.g. in the gradle IT scenarios).
@manusa manusa self-assigned this May 25, 2023
@manusa manusa added the bug Something isn't working label May 25, 2023
@manusa manusa added this to the 1.13.0 milestone May 25, 2023
@manusa manusa mentioned this issue May 25, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manusa manusa

Labels
bug Something isn't working
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

fix: profile merge constructor accounts for parentProfile field manusa/jkube
1 participant
@manusa