Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubernetesRemoteDevTaskTest.tearDown The declared Exception exception is never thrown #2717

Closed
1 task done
manusa opened this issue Feb 22, 2024 · 5 comments · Fixed by #2734
Closed
1 task done
Assignees
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Milestone

Comments

@manusa
Copy link
Member

manusa commented Feb 22, 2024

Description

The method KubernetesRemoteDevTaskTest.tearDown declares an Exception that is never thrown.

The following line
https://github.com/eclipse/jkube/blob/5da6068d7756784aef9569568ee80f98da97e296/gradle-plugin/kubernetes/src/test/java/org/eclipse/jkube/gradle/plugin/task/KubernetesRemoteDevTaskTest.java#L61

  • should be changed to:
  void tearDown() {

Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇👇👇👇👇👇👇
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

@manusa manusa added good first issue Good for newcomers first-timers-only Is this your first time contributing? This could be a good place to start! labels Feb 22, 2024
@josh-segal
Copy link
Contributor

I would like to work on this issue. Can it be assigned to me?

@josh-segal
Copy link
Contributor

Hi, would someone be able to guide me to resources on manually testing my changes with minikube?

@manusa
Copy link
Member Author

manusa commented Feb 26, 2024

Hi, would someone be able to guide me to resources on manually testing my changes with minikube?

Your changes only apply to a unit test, so the manual testing doesn't apply in this context.

@josh-segal
Copy link
Contributor

Hi, would someone be able to guide me to resources on manually testing my changes with minikube?

Your changes only apply to a unit test, so the manual testing doesn't apply in this context.

I would like to contribute further and I am having trouble building and deploying the project.
Is there a tutorial that can help me build and deploy this project using minikube?

@manusa
Copy link
Member Author

manusa commented Mar 1, 2024

Is there a tutorial that can help me build and deploy this project using minikube?

This is not a deployable application, it's a tool to deploy other applications.

Once you build and install the application locally (mvn clean install or mvn clean install -DskipTests if on Windows -tests won't pass-), you can then use Minikube or anything else to deploy your application.

You can then follow one of the "Getting Started" guides in our documentation.
For Minikube: https://eclipse.dev/jkube/docs/kubernetes-maven-plugin/#minikube-gettingstarted

Now, instead of using the version showed in the documentation, you can use the current SNAPSHOT you've just built and installed (at this moment 1.17-SNAPSHOT).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Projects
None yet
2 participants