-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check local port available on start remote-dev #2003
fix: check local port available on start remote-dev #2003
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #2003 (2023-01-25T15:22:49Z) ⚙️ JKube E2E Tests (4007054535)
|
ddb9bd3
to
742a5f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx! (tests need to be addressed though)
Codecov Report
@@ Coverage Diff @@
## master #2003 +/- ##
============================================
+ Coverage 54.08% 54.14% +0.05%
- Complexity 4045 4050 +5
============================================
Files 480 480
Lines 21061 21061
Branches 2812 2812
============================================
+ Hits 11391 11403 +12
+ Misses 8499 8486 -13
- Partials 1171 1172 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
...t/remote-dev/src/test/java/org/eclipse/jkube/kit/remotedev/RemoteDevelopmentServiceTest.java
Outdated
Show resolved
Hide resolved
...t/remote-dev/src/test/java/org/eclipse/jkube/kit/remotedev/RemoteDevelopmentServiceTest.java
Outdated
Show resolved
Hide resolved
742a5f3
to
00482ad
Compare
00482ad
to
043def3
Compare
043def3
to
b55162b
Compare
Signed-off-by: Marc Nuri <marc@marcnuri.com>
SonarCloud Quality Gate failed. |
Description
Fixes verify remote services local port available before start remote-dev
Type of change
test, version modification, documentation, etc.)
Checklist
[ ] I have updated the documentation accordingly[ ] No new bugs, code smells, etc. in SonarCloud report