Found the limitation of getCurrentAttributeName() method of AbstractPositionRequest class

[Seiphon]

Hi @angelozerr and @fbricon

I found a limitation for getCurrentAtrributeName() method of AbstractPositionReqest class.

When I try to support hover feature for attribute name, I found it's difficult to get correct attribute name.
@Override public String getCurrentAttributeName() { return currentAttributeName; }

It because before we use get method, we should set the attribute name first (Like XMLCompletions.doComplete method does).

How about try to get the attribute name by DOM first. Like getCurrentTag() does.
Like follows:

@Override
public String getCurrentAttributeName() {
if (node != null && node.isAttribute() && ((DOMAttr) node).getName() != null) {
return ((DOMAttr) node).getName();
}
return currentAttributeName;
}

[Seiphon]

Please see this PR #584.

[angelozerr]

@Seiphon please add a test with your usecase.

[Seiphon]

@Seiphon please add a test with your usecase.

Hi @angelozerr , I added a test on AggregetedHoverValuesTest. If it's not allowable, I will add a new test class for it.

[angelozerr]

Fixed with #584