Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CoapRequestBuilder about BootstrapDeleteRequest request which could target "none root" path #627

Closed
sbernard31 opened this issue Dec 7, 2018 · 0 comments
Labels
bsserver Impact LWM2M bootstrap server bug Dysfunctionnal behavior

Comments

@sbernard31
Copy link
Contributor

From (https://www.eclipse.org/lists/leshan-dev/msg01023.html)
In commit fe58a35 ("BootstrapDelete Request can target "none root" path.") has been added possibility to delete "none-root" objects during bootstrap procedure
As I understand this change must be synchronized with method org.eclipse.leshan.server.californium.impl.CoapRequestBuilder.visit(BootstrapDeleteRequest request)
where COAP request is being formed :

    @Override
    public void visit(BootstrapDeleteRequest request) {
        coapRequest = Request.newDelete();
        coapRequest.setConfirmable(true);
        EndpointContext context = EndpointContextUtil.extractContext(destination);
        coapRequest.setDestinationContext(context);
        // here probably we have to call setTarget(coapRequest, request.getPath()); 
        // by analogue with rest methods of visitor
    }
@sbernard31 sbernard31 added bug Dysfunctionnal behavior bsserver Impact LWM2M bootstrap server labels Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bsserver Impact LWM2M bootstrap server bug Dysfunctionnal behavior
Projects
None yet
Development

No branches or pull requests

1 participant