Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for client/executeCommand request #468

Closed
kdvolder opened this issue Nov 6, 2020 · 1 comment
Closed

Add support for client/executeCommand request #468

kdvolder opened this issue Nov 6, 2020 · 1 comment
Labels

Comments

@kdvolder
Copy link

kdvolder commented Nov 6, 2020

This is a protocol extension that I have proposed here: microsoft/language-server-protocol#1117
It allows a server to request the client to execute a command.

Also related: eclipse-wildwebdeveloper/wildwebdeveloper#543

This adds some custom protocol to xml language server that does essentially the same thing.

It was suggested that instead, if we could hasten the adoption/implementation of this (hopefully soon) to be standardized message into LSP4e and LSP4j, then that particular PR and its custom extension becomes obsolete, saving work all around.

That seems like a good solution to me if it can be done relatively quickly. I'm willing to create PR against LSP4J for this.

However the question (here eclipse-wildwebdeveloper/wildwebdeveloper#543 (comment)) is whether you guys would be okay with doing this before the LSP extension is officially part of the protocol). @mickaelistria is okay with this for the lsp4e side, but can't speak for LSP4J.

@jonahgraham
Copy link
Contributor

@kdvolder sorry you didn't get an answer to this earlier - and I can't provide one for you now (I am more on the DAP side, rather than the LSP side). I believe that in the past only official releases and pre-releases of the spec have made it into LSP4J. I believe that the whole idea of the extensibility that the protocol can be extended by the clients and if the protocol is approved then we can move it to LSP4J in line with the LSP spec release. Indeed it looks like this was done already (in WWD)?

I am closing this for now as I think I have answered your question (and perhaps pinged others to revisit the question).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants