Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[releng] CompletionProposalTests disabled for Tycho #1903

Open
eclipse-ocl-bot opened this issue Sep 25, 2024 · 9 comments
Open

[releng] CompletionProposalTests disabled for Tycho #1903

eclipse-ocl-bot opened this issue Sep 25, 2024 · 9 comments

Comments

@eclipse-ocl-bot
Copy link
Collaborator

| --- | --- |
| Bugzilla Link | 526252 |
| Status | NEW |
| Importance | P3 normal |
| Reported | Oct 19, 2017 04:01 EDT |
| Modified | Mar 11, 2024 06:44 EDT |
| Depends on | 526019, 529797 |
| Blocks | 499509 |
| See also | 526567, 529886, 582953 |
| Reporter | Ed Willink |

Description

Unfortunately the tycho-surefire-tests require the JUnit Plugin launch configuration to be transliterated. This mostly works but:

The CompletionProposalTests do a "project.build" that requires the PlatformAdmin service to be available. This comes from the org.eclipse.osgi.compatibility.state fragment which the standard PDE launch activates but tycho-surefire does not.

No doubt an expert could solve this with applications/products/requirements/dependencies. I've spent too long on this minor test failure. For now two tests are disabled in the Tycho testing. Tests still available from the JUnit Plugin launch.

@eclipse-ocl-bot
Copy link
Collaborator Author

By Ed Willink on Oct 19, 2017 04:15

The ConsoleTests.testConsole_debugger is disabled probably for the same reason. consolePage.launchDebugger() returns null.

@eclipse-ocl-bot
Copy link
Collaborator Author

By Ed Willink on Nov 16, 2017 14:39

This also affects the QVTi debugger tests (no launch).

@eclipse-ocl-bot
Copy link
Collaborator Author

By Ed Willink on Jan 14, 2018 05:23

Adding the org.eclipse.osgi.compatibility.state fragment as an extraRequirement solves the missing PlatformAdmin issue.

One of the two CompletionProposalTests passes, the other now fails in a more plausible fashion; a missing proposal that comments suggest should have come from a JAR. Probably another effect of packed TYcho testing wrt unpackaged Buckminster testing.

There is no change to the debugger launch returning null.

@eclipse-ocl-bot
Copy link
Collaborator Author

By Ed Willink on Jan 17, 2018 17:08

Although one test was enabled Bug 529797 required many more to be disabled.

@eclipse-ocl-bot
Copy link
Collaborator Author

By Ed Willink on Mar 21, 2018 11:42

(In reply to Ed Willink from comment #4)

Although one test was enabled Bug 529797 required many more to be disabled.

The Bug 529797 disables have been solved.

One CompletionProposal test (this bug) remains disabled. Probably a simple Tycho packaged path bug.

The DebuggerTests are not yet useable see Bug 529886.

@eclipse-ocl-bot
Copy link
Collaborator Author

By Ed Willink on Mar 24, 2018 04:16

(In reply to Ed Willink from comment #5)

One CompletionProposal test (this bug) remains disabled.

Revising to use a coherent TestFileSystem and we seem to get a JUnit Plugin test failure too; easier to debug. Seems that the .project is not created correctly / builder is not running in time / previous errors were ignored....

@eclipse-ocl-bot
Copy link
Collaborator Author

By Ed Willink on Mar 29, 2018 08:53

(In reply to Ed Willink from comment #6)

Seems that the .project is not created correctly

Instrumenting JavaClassScope.doFullScan confirms that the MANIFEST.MF dependencies have been ignored.

Putting in mega-waits around a close/refresh/open/build makes no difference, but allows interactive probing. The Test.java file has an error. org.eclipse.emf not found. There is no Manifest editor. The installed plugin list shows no PDE plugins.

@eclipse-ocl-bot
Copy link
Collaborator Author

By Ed Willink on Mar 30, 2018 08:22

Adding the most obvious UI/PDE/Equinox plugins makes no difference.

One difference: the PDE JUnit test uses a product whereas TYcho uses an application. However changing PDE to an application and/or Tychoo to a product makes no difference.

The obstinate refusal of the Tycho project to build using an interactive intervention is reminiscent of normal Eclipse behaviour after some changes. It sometimes needs a restart.

Perhaps adding the Manifest after creating the project is the problem. But closing and opening and refreshing doesn't help.

The fundamental error seems to be in the manifest editor where the two required plugins are reported as unresolved even though they are installed plugins. Some bundle resolution service is perhaps not running. Perhaps confused by multiple alternatives from a Tycho target area and a normal jar.

This has burned another couple of days with no real progress for a minor test limitation. Back into the long grass.

@eclipse-ocl-bot
Copy link
Collaborator Author

By Ed Willink on Jun 21, 2019 05:29

(In reply to Ed Willink from comment #8)

Perhaps adding the Manifest after creating the project is the problem.

The QVTd auto-generated projects have been upgraded to have manifests etc. Promoting this technology to OCL might solve the problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant