SympleTypeEnum has not been actualized in OCLCST

[eclipse-ocl-bot]

| --- | --- |
| Bugzilla Link | 288526 |
| Status | CLOSED FIXED |
| Importance | P3 minor |
| Reported | Sep 03, 2009 13:03 EDT |
| Modified | May 27, 2011 02:47 EDT |
| Reporter | Adolfo Sanchez-Barbudo Herrera |

Description

Resolution https://bugs.eclipse.org/bugs/show_bug.cgi?id=282882 didn't properly fix the SympleTypeEnum of the CST metamodel.

I'll attach a patch for this.

[eclipse-ocl-bot]

By Adolfo Sanchez-Barbudo Herrera on Sep 03, 2009 13:05

Created attachment 146423 (attachment deleted)
Fixing patch

I need +1 to patch

[eclipse-ocl-bot]

By Adolfo Sanchez-Barbudo Herrera on Sep 03, 2009 13:07

My apologies.

I didn't properly set the component.

P.S: Assigning to me.

[eclipse-ocl-bot]

By Ed Willink on Sep 03, 2009 15:14

+1 Well caught. Hopefully this finishes this completely.

[eclipse-ocl-bot]

By Ed Willink on Sep 03, 2009 16:19

Two missing @SInCE 3.0's.

Found another:

ToStringVisitor.visitInvalidLiteralExp should now return "invalid". Can you do that at the same time please?

[eclipse-ocl-bot]

By Adolfo Sanchez-Barbudo Herrera on Sep 03, 2009 16:27

(In reply to comment #4)

Two missing @SInCE 3.0's.

Found another:

ToStringVisitor.visitInvalidLiteralExp should now return "invalid". Can you do
that at the same time please?

Ok Ed,

I think that I had disactivated API tooling warnings, in that workspace. I'll fix all toguether and commit

Thanks for pointing it out.

Cheers,
Adolfo.

[eclipse-ocl-bot]

By Adolfo Sanchez-Barbudo Herrera on Sep 04, 2009 06:14

Created attachment 146487
Final patch including commented changes

At the end, I hadn't configured the API Baseline in the workspace in which I created the patch >.<.

Another point, is that if your regenerate, you lose @SInCE :\

:notepad_spiral: ocl288526.patch

[eclipse-ocl-bot]

By Adolfo Sanchez-Barbudo Herrera on Sep 04, 2009 06:19

Committed to HEAD.

[eclipse-ocl-bot]

By Ed Willink on Sep 04, 2009 08:37

(In reply to comment #6)

Another point, is that if your regenerate, you lose @SInCE :\

For EMF auto-generation if you put @SInCE within the user-comments section, it is preserved.

[eclipse-ocl-bot]

By Ed Willink on Sep 04, 2009 09:42

Since the LPG templates do not provide all the NLS annotations you have to transfer them across manually. Fairly easy while in the Synchronize with Repository Perspective to just compare evetything with a yellow warning.

I've restored them as part of the commit for 287993.

When committing, the commits should very rarely have any yellow warnings (or red errors).

[eclipse-ocl-bot]

By Adolfo Sanchez-Barbudo Herrera on Sep 04, 2009 13:06

Ed,

Thank's for the advise. I'll take it into acount ;)

Cheers,
Adolfo.

[eclipse-ocl-bot]

By Ed Willink on May 27, 2011 02:47

Closing after over 18 months in resolved state.