Updated selection when switched from bnd to standard equinox #1502
Conversation
nburnwal09
force-pushed
the
pluginProjectType_Fix
branch
from
cdef177 to
725f3c1
Compare
|
@laeubi @HannesWell - can you please have a look? thanks! |
laeubi
force-pushed
the
pluginProjectType_Fix
branch
from
725f3c1 to
32d72df
Compare
| @@ -162,6 +162,9 @@ protected void createFormatGroup(Composite container) { | |||
| private void updateAutomatic() { | |||
| boolean standardSelected = PDEUIMessages.NewProjectCreationPage_standard.equals(fOSGiCombo.getText()); | |||
| useAutomaticMetadata.setVisible(standardSelected); | |||
| if (!standardSelected) { | |||
| useAutomaticMetadata.setSelection(false); | |||
There was a problem hiding this comment.
I'm not sure it should be fixed in the UI but at the place where the value is evaluated.
There was a problem hiding this comment.
I will look into the possibility and get back.
There was a problem hiding this comment.
We cannot stop it where the values are getting loaded as it is needed for standard selection bundles(when Generate OSGi metadata automatically is selected Unser standard)
As the problem occurs when moved from bnd to standard equinox, we need to make it False in the UI.
There was a problem hiding this comment.
As the problem occurs when moved from bnd to standard equinox, we need to make it False in the UI.
I don't agree here, the UI is just showing a state. If that state is not valid or irrelevant then it should be assumed to be false on this place (or not being evaluated at all).
There was a problem hiding this comment.
I have updated the fix accordingly. Kindly check
But I have a question here:
Does the checkbox 'This plug-in will make contributions to the UI' need to be enabled only for Eclipse projects? I notice that it is greyed out for the both OSGi framework -> standard Equinox and bnd(with checked or unchecked generate automatic metadata)
There was a problem hiding this comment.
This plug-in will make contributions to the UI
Yes this is eclipse specific, in standard OSGi there is no mean of "UI", this is application specific. Still a "standard" plugin can of course contribute to the UI... it just controls what is offered to the user and some initial settings but nothing that is persisted.
nburnwal09
force-pushed
the
pluginProjectType_Fix
branch
from
9c53a54 to
ca40a1b
Compare
laeubi
force-pushed
the
pluginProjectType_Fix
branch
from
ca40a1b to
f93822e
Compare
This commit fixes the bnd in templates while switching the plugin project type from bnd(with checked 'Generate OSGi metadata automatically' ) to standard equinox
Fixes: #1500