Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pde.ui repository to pde #35

Closed
vogella opened this issue Apr 21, 2022 · 11 comments
Closed

Rename pde.ui repository to pde #35

vogella opened this issue Apr 21, 2022 · 11 comments
Assignees
Milestone

Comments

@vogella
Copy link
Contributor

vogella commented Apr 21, 2022

pde.ui is a merge of pde.core and pde.ui. I suggest we rename the repo to eclipse.pde.

@vik-chand OK for you? This can be easily done by the foundation and Github will forward the old repo requests to the new one.

I did this with GEF classic without encountering any issues.

@vogella vogella changed the title Rename pde.ui to pde Rename pde.ui repository to pde Apr 21, 2022
@akurtakov
Copy link
Member

@sravanlakkimsetti FYI as change in aggregator submodules would be required for this.

@vogella
Copy link
Contributor Author

vogella commented Apr 21, 2022

@akurtakov I think Github would forward to the new repo but of course we should update the URL after the rename just to avoid storing old data / URLs.

@HannesWell
Copy link
Member

Sounds reasonable.
Will this be just a rename of the existing repo so that issues/PR continue to exist just as they are with only a new URL?

@vogella
Copy link
Contributor Author

vogella commented Apr 22, 2022

Sounds reasonable. Will this be just a rename of the existing repo so that issues/PR continue to exist just as they are with only a new URL?

Just a rename. For https://github.com/eclipse/gef-classic which used to be https://github.com/eclipse/gef-legacy it worked flawless, also existing PR were still intact.

@vik-chand please approve.

@vik-chand
Copy link
Member

Looks good to me.

@vogella
Copy link
Contributor Author

vogella commented Apr 22, 2022

@HannesWell
Copy link
Member

Just a rename. For https://github.com/eclipse/gef-classic which used to be https://github.com/eclipse/gef-legacy it worked flawless, also existing PR were still intact.

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1199

Thanks!

@vogella
Copy link
Contributor Author

vogella commented Apr 22, 2022

Done

@vogella
Copy link
Contributor Author

vogella commented Apr 22, 2022

@HannesWell
Copy link
Member

Thank you Lars!
Is this task then completed and we can close this?

@vik-chand vik-chand added this to the 4.24 M2 milestone Apr 24, 2022
@vik-chand
Copy link
Member

I think we are done here. There was a javadoc/releng test failure issue which I have fixed ( hopefully).

eclipse-platform/eclipse.platform.common#13

@vik-chand vik-chand assigned vogella and unassigned vik-chand Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants