-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing unjar of content.jar #2518
Conversation
This fix will remove the extracing of content.jar file and retain existing content.jar and content.xml.xz Fix eclipse-platform#1912
I have no memories about this and fully defer to you guys to figure it out. |
IIRC, the content.xml is tweaked in some further steps, and since p2 preferes xml.xz or jar, if those files are still present and only the content.xml is tweaked, then the tweaks will not be found by consumers (as .xml.xz without trick will be processed instead) |
do you mean that still we need to retain content.xml with jar and xz ? |
I'm traveling so have no time for reviews. I assume that nothing (no script) is altering the contents of content.jar after it is produced by p2. A "normal" simple p2 repository has just these files: |
The very next mojo execution execution in pom.xml with id |
Shall we then try to extract the content.jar to another target ? and retain .jar and .xz |
IMO you should investigate why the jar has to be extracted and it's content manipulated after that and remove the need for that. |
Sure 👍 |
I'm closing this one as the real change will have to be quite different. |
This fix will remove the extracing of content.jar file and retain existing content.jar and content.xml.xz
Fix #1912
Output [local]-