Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unjar of content.jar #2518

Closed
wants to merge 1 commit into from

Conversation

SougandhS
Copy link
Contributor

This fix will remove the extracing of content.jar file and retain existing content.jar and content.xml.xz

Fix #1912

Output [local]-
image

This fix will remove the extracing of content.jar file and retain
existing content.jar and content.xml.xz

Fix eclipse-platform#1912
@akurtakov
Copy link
Member

I have no memories about this and fully defer to you guys to figure it out.

@mickaelistria
Copy link
Contributor

IIRC, the content.xml is tweaked in some further steps, and since p2 preferes xml.xz or jar, if those files are still present and only the content.xml is tweaked, then the tweaks will not be found by consumers (as .xml.xz without trick will be processed instead)

@SougandhS
Copy link
Contributor Author

IIRC, the content.xml is tweaked in some further steps, and since p2 preferes xml.xz or jar, if those files are still present and only the content.xml is tweaked, then the tweaks will not be found by consumers (as .xml.xz without trick will be processed instead)

do you mean that still we need to retain content.xml with jar and xz ?

@merks
Copy link
Contributor

merks commented Nov 6, 2024

I'm traveling so have no time for reviews. I assume that nothing (no script) is altering the contents of content.jar after it is produced by p2. A "normal" simple p2 repository has just these files:

https://download.eclipse.org/releases/2024-09/202409111000/

image

@mickaelistria
Copy link
Contributor

The very next mojo execution execution in pom.xml with id generate-extra-iu tweaks the content.xml file after it's produced. As long as we use it, we need to clear the .jar and .xml.xz (and optionally recreate them later from the altered content.xml).
There might be better ways to do that, such as using p2 instructions in a p2.inf file. If we can leverage such more standard approach, then we may be more easily able to get rid of some executions.

@SougandhS
Copy link
Contributor Author

The very next mojo execution execution in pom.xml with id generate-extra-iu tweaks the content.xml file after it's produced. As long as we use it, we need to clear the .jar and .xml.xz (and optionally recreate them later from the altered content.xml). There might be better ways to do that, such as using p2 instructions in a p2.inf file. If we can leverage such more standard approach, then we may be more easily able to get rid of some executions.

Shall we then try to extract the content.jar to another target ? and retain .jar and .xz

@akurtakov
Copy link
Member

IMO you should investigate why the jar has to be extracted and it's content manipulated after that and remove the need for that.

@SougandhS
Copy link
Contributor Author

IMO you should investigate why the jar has to be extracted and it's content manipulated after that and remove the need for that.

Sure 👍

@akurtakov
Copy link
Member

I'm closing this one as the real change will have to be quite different.

@akurtakov akurtakov closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The https://download.eclipse.org/eclipse/updates/4.32-I-builds don't have a content.jar/content.xml.xz
4 participants