Fix for runWithAutoScaleValue

akoch-yatta · akoch-yatta · commit 0d599f2007c6 · 2025-04-17T14:59:04.000+02:00
This commit addresses and issue with DPIUtil#runWithAutoScaleValue. It only adapted DPIUtil#autoScaleValue temporarily. As DPIUtil#deviceZoom is directly affected by autoScaleValue, it is important to adjust it temporarily as well. fixes eclipse-platform/eclipse.platform.ui#2897
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/DPIUtil.java b/bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/DPIUtil.java
@@ -671,10 +671,12 @@ private static int getZoomForAutoscaleProperty (int nativeDeviceZoom, String aut
 public static void runWithAutoScaleValue(String autoScaleValue, Runnable runnable) {
 	String initialAutoScaleValue = DPIUtil.autoScaleValue;
 	DPIUtil.autoScaleValue = autoScaleValue;
+	DPIUtil.deviceZoom = getZoomForAutoscaleProperty(nativeDeviceZoom);
 	try {
 		runnable.run();
 	} finally {
 		DPIUtil.autoScaleValue = initialAutoScaleValue;
+		DPIUtil.deviceZoom = getZoomForAutoscaleProperty(nativeDeviceZoom);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -671,10 +671,12 @@ private static int getZoomForAutoscaleProperty (int nativeDeviceZoom, String aut`
`671`	`671`	`public static void runWithAutoScaleValue(String autoScaleValue, Runnable runnable) {`
`672`	`672`	`String initialAutoScaleValue = DPIUtil.autoScaleValue;`
`673`	`673`	`DPIUtil.autoScaleValue = autoScaleValue;`
	`674`	`+ DPIUtil.deviceZoom = getZoomForAutoscaleProperty(nativeDeviceZoom);`
`674`	`675`	`try {`
`675`	`676`	`runnable.run();`
`676`	`677`	`} finally {`
`677`	`678`	`DPIUtil.autoScaleValue = initialAutoScaleValue;`
	`679`	`+ DPIUtil.deviceZoom = getZoomForAutoscaleProperty(nativeDeviceZoom);`
`678`	`680`	`}`
`679`	`681`	`}`
`680`	`682`