Declare constant in CTabFolder to be public

Author: fedejeanne

bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/internal/workbench/renderers/swt/BasicPartList.java

@@ -229,9 +229,8 @@ private boolean shouldHideIcons() {
 		}
 
 		// Get the preference value for hiding icons in view tabs
-		// Note: The preference qualifier is hardcoded here as it's private in CTabRendering
 		return Platform.getPreferencesService().getBoolean(
-				"org.eclipse.e4.ui.workbench.renderers.swt", //$NON-NLS-1$
+				CTabRendering.PREF_QUALIFIER_ECLIPSE_E4_UI_WORKBENCH_RENDERERS_SWT,
 				CTabRendering.HIDE_ICONS_FOR_VIEW_TABS,
 				CTabRendering.HIDE_ICONS_FOR_VIEW_TABS_DEFAULT,
 				null);

bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java

@@ -47,7 +47,7 @@ public class CTabRendering extends CTabFolderRenderer implements ICTabRendering,
 	/**
 	 * The preference qualifier.
 	 */
-	private static final String PREF_QUALIFIER_ECLIPSE_E4_UI_WORKBENCH_RENDERERS_SWT = "org.eclipse.e4.ui.workbench.renderers.swt"; //$NON-NLS-1$
+	public static final String PREF_QUALIFIER_ECLIPSE_E4_UI_WORKBENCH_RENDERERS_SWT = "org.eclipse.e4.ui.workbench.renderers.swt"; //$NON-NLS-1$
 
 	/**
 	 * A named preference for setting CTabFolder's to be rendered with rounded

bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java

@@ -161,7 +161,7 @@ public class StackRenderer extends LazyStackRenderer {
 	private static final String TAB_FONT_KEY = "org.eclipse.ui.workbench.TAB_TEXT_FONT"; //$NON-NLS-1$
 
 	@Inject
-	@Preference(nodePath = "org.eclipse.e4.ui.workbench.renderers.swt")
+	@Preference(nodePath = CTabRendering.PREF_QUALIFIER_ECLIPSE_E4_UI_WORKBENCH_RENDERERS_SWT)
 	private IEclipsePreferences preferences;
 
 	@Inject

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/WorkbookEditorsHandler.java

@@ -33,6 +33,7 @@
 import org.eclipse.core.runtime.preferences.IEclipsePreferences;
 import org.eclipse.core.runtime.preferences.InstanceScope;
 import org.eclipse.e4.ui.model.application.ui.basic.MPart;
+import org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering;
 import org.eclipse.e4.ui.workbench.renderers.swt.StackRenderer;
 import org.eclipse.jface.viewers.BoldStylerProvider;
 import org.eclipse.jface.viewers.ColumnViewerToolTipSupport;
@@ -62,11 +63,6 @@
  */
 public class WorkbookEditorsHandler extends FilteredTableBaseHandler {
 
-	/**
-	 * Preference node for the workbench SWT renderer
-	 */
-	private static final String ORG_ECLIPSE_E4_UI_WORKBENCH_RENDERERS_SWT = "org.eclipse.e4.ui.workbench.renderers.swt"; //$NON-NLS-1$
-
 	/**
 	 * Id for the command that opens the editor drop down
 	 */
@@ -98,7 +94,7 @@ public class WorkbookEditorsHandler extends FilteredTableBaseHandler {
 	 * @return Returns the enableMRU.
 	 */
 	private static boolean isMruEnabled() {
-		IEclipsePreferences preferences = InstanceScope.INSTANCE.getNode(ORG_ECLIPSE_E4_UI_WORKBENCH_RENDERERS_SWT);
+		IEclipsePreferences preferences = InstanceScope.INSTANCE.getNode(CTabRendering.PREF_QUALIFIER_ECLIPSE_E4_UI_WORKBENCH_RENDERERS_SWT);
 		boolean initialMRUValue = preferences.getBoolean(StackRenderer.MRU_KEY_DEFAULT, StackRenderer.MRU_DEFAULT);
 		return preferences.getBoolean(StackRenderer.MRU_KEY, initialMRUValue);
 	}

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java

@@ -92,8 +92,6 @@
  */
 public class ViewsPreferencePage extends PreferencePage implements IWorkbenchPreferencePage {
 
-	private static final String PREF_QUALIFIER_ECLIPSE_E4_UI_WORKBENCH_RENDERERS_SWT = "org.eclipse.e4.ui.workbench.renderers.swt"; //$NON-NLS-1$
-
 	private static final String E4_THEME_EXTENSION_POINT = "org.eclipse.e4.ui.css.swt.theme"; //$NON-NLS-1$
 
 	/** The workbench theme engine; may be {@code null} if no engine */
@@ -248,7 +246,7 @@ protected void createHideIconsForViewTabs(Composite composite) {
 	}
 
 	private boolean getSwtRendererPreference(String prefName, boolean defaultValue) {
-		return Platform.getPreferencesService().getBoolean(PREF_QUALIFIER_ECLIPSE_E4_UI_WORKBENCH_RENDERERS_SWT,
+		return Platform.getPreferencesService().getBoolean(CTabRendering.PREF_QUALIFIER_ECLIPSE_E4_UI_WORKBENCH_RENDERERS_SWT,
 				prefName, defaultValue, null);
 	}
 
@@ -332,7 +330,7 @@ public void init(IWorkbench workbench) {
 	@Override
 	public boolean performOk() {
 		IEclipsePreferences prefs = InstanceScope.INSTANCE
-				.getNode(PREF_QUALIFIER_ECLIPSE_E4_UI_WORKBENCH_RENDERERS_SWT);
+				.getNode(CTabRendering.PREF_QUALIFIER_ECLIPSE_E4_UI_WORKBENCH_RENDERERS_SWT);
 		if (isThemingPossible()) {
 			ITheme theme = getSelectedTheme();
 			if (theme != null) {
@@ -441,7 +439,7 @@ private void setColorsAndFontsTheme(ColorsAndFontsTheme theme) {
 	@Override
 	protected void performDefaults() {
 		IEclipsePreferences defaultPrefs = DefaultScope.INSTANCE
-				.getNode(PREF_QUALIFIER_ECLIPSE_E4_UI_WORKBENCH_RENDERERS_SWT);
+				.getNode(CTabRendering.PREF_QUALIFIER_ECLIPSE_E4_UI_WORKBENCH_RENDERERS_SWT);
 		if (isThemingPossible()) {
 			setColorsAndFontsTheme(currentColorsAndFontsTheme);