Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Run As" Context Menu shows Ant Run Configurations multiple times #527

Closed
jukzi opened this issue Jun 15, 2023 · 9 comments · Fixed by #800 · May be fixed by #730
Closed

"Run As" Context Menu shows Ant Run Configurations multiple times #527

jukzi opened this issue Jun 15, 2023 · 9 comments · Fixed by #800 · May be fixed by #730
Labels
bug Something isn't working regression Regression defect

Comments

@jukzi
Copy link
Contributor

jukzi commented Jun 15, 2023

image
example from platform worspace: /org.eclipse.jdt.ui/scripts/build_jar-in-jar-loader.xml

@mickaelistria probably caused by the changes in that menu
@mickaelistria
Copy link
Contributor

Indeed. We could easily de-deduplicate results.

@laeubi
Copy link
Contributor

laeubi commented Jun 15, 2023

I think one should check the implementation as well, for me it seems the second variant should not implement the ILaunchShotcut2 interface in a way to return launch configs, that does not seems right as it claims to always open a dialog.

@laeubi laeubi transferred this issue from eclipse-platform/eclipse.platform.debug Jul 1, 2023
@jukzi
Copy link
Contributor Author

jukzi commented Aug 29, 2023

@mickaelistria still happens
image

@jukzi jukzi added bug Something isn't working regression Regression defect labels Aug 29, 2023
@sudhindrakkulkarni102
Copy link

From the above discussion I understand that the shortcuts are duplicated and only one shortcut(context menu entry highlighted in yellow) should be ideally shown. Please confirm if my understanding is correct.

@laeubi
Copy link
Contributor

laeubi commented Sep 12, 2023

Yes that is correct.

SudhindraKKulkarni added a commit to SudhindraKKulkarni/eclipse.platform that referenced this issue Oct 6, 2023
@SudhindraKKulkarni
Run As Context Menu shows Ant Run Configurations multiple times eclip…
f07f882 
…se-platform#527

AntLaunchShortcutWithDialog now implements only ILaunchShortcut
interface.
The common implementation of AntLaunchShortcut and
AntLaunchShortcutWithDialog are moved to AntLaunchShortcutCommon class

Fixes eclipse-platform#527
@SudhindraKKulkarni SudhindraKKulkarni mentioned this issue Oct 6, 2023
Open
@SudhindraKKulkarni
Copy link

@jukzi Please review and confirm if the the changes in the pull request are fine.

@Bananeweizen
Copy link
Contributor

I've raised #798 for another duplication of launch configs. Just saying, if someone is touching code for filtering duplicates...

@jukzi
Copy link
Contributor Author

jukzi commented Nov 2, 2023

Indeed. We could easily de-deduplicate results.

@mickaelistria can you please review the proposed PR, i am not into the implementation details. I only see that the change looks more complicated then an easy de-duplication.

@laeubi laeubi mentioned this issue Nov 2, 2023
Open
laeubi added a commit to laeubi/eclipse.platform that referenced this issue Nov 2, 2023
@laeubi
Deduplicate launch configs
0a9a954 
The same launch config might be returned by multiple
LaunchShortcutExtension and is then shown twice.

This simply filter items that where already seen to deduplicate such
entries.

Fix eclipse-platform#527
@laeubi laeubi mentioned this issue Nov 2, 2023
Merged
@laeubi
Copy link
Contributor

laeubi commented Nov 2, 2023

See

for generic deduplication, but

should still be considered as it fixes the root of the problem.

laeubi added a commit to laeubi/eclipse.platform that referenced this issue Nov 29, 2023
@laeubi
Deduplicate launch configs
28df400 
The same launch config might be returned by multiple
LaunchShortcutExtension and is then shown twice.

This simply filter items that where already seen to deduplicate such
entries.

Fix eclipse-platform#527
laeubi added a commit to laeubi/eclipse.platform that referenced this issue Nov 30, 2023
@laeubi
Deduplicate launch configs
c74bc29 
The same launch config might be returned by multiple
LaunchShortcutExtension and is then shown twice.

This simply filter items that where already seen to deduplicate such
entries.

Fix eclipse-platform#527
laeubi added a commit to laeubi/eclipse.platform that referenced this issue Nov 30, 2023
@laeubi
Deduplicate launch configs
82bacbc 
The same launch config might be returned by multiple
LaunchShortcutExtension and is then shown twice.

This simply filter items that where already seen to deduplicate such
entries.

Fix eclipse-platform#527
laeubi added a commit that referenced this issue Nov 30, 2023
@laeubi
Deduplicate launch configs
f1c9085 
The same launch config might be returned by multiple
LaunchShortcutExtension and is then shown twice.

This simply filter items that where already seen to deduplicate such
entries.

Fix #527
Michael5601 pushed a commit to CodeLtDave/eclipse.platform that referenced this issue Feb 12, 2024
@laeubi @Michael5601
Deduplicate launch configs
e0d3e44 
The same launch config might be returned by multiple
LaunchShortcutExtension and is then shown twice.

This simply filter items that where already seen to deduplicate such
entries.

Fix eclipse-platform#527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working regression Regression defect
Projects
None yet
Milestone
No milestone
6 participants
@Bananeweizen @mickaelistria @laeubi @jukzi @sudhindrakkulkarni102 @SudhindraKKulkarni