Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PluginTree ID generation algorithm generates identical ID's #12337

Closed
colin-grant-work opened this issue Mar 22, 2023 · 0 comments · Fixed by #12338
Closed

New PluginTree ID generation algorithm generates identical ID's #12337

colin-grant-work opened this issue Mar 22, 2023 · 0 comments · Fixed by #12338
Labels
plug-in system issues related to the plug-in system tree issues related to the tree (ex: tree widget)

Comments

@colin-grant-work
Copy link
Contributor

Bug Description:

More details here

cc: @tsmaeder

Steps to Reproduce:

  1. Set up a pair of TS files like this:

image

  1. Do a reference search for the variable a
  2. First, note that not all references are found - in this screenshot, only two console logs are shown, because some of them have the same ID, so the tree only shows one.
  3. Repeat the reference search.
  4. The application will freeze and eventually crash, trapped in a loop in TopDownTreeIterator because the nodes with the same ID's end up being their own siblings, so the iteration is infinite.

Additional Information

  • Operating System: RHEL
  • Theia Version: 1ca8131
@colin-grant-work colin-grant-work added tree issues related to the tree (ex: tree widget) plug-in system issues related to the plug-in system labels Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system tree issues related to the tree (ex: tree widget)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant