Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposed API][builtins] Theia misses proposed API: TerminalQuickFixProvider #12522

Closed
marcdumais-work opened this issue May 11, 2023 · 0 comments · Fixed by #12532
Closed

[proposed API][builtins] Theia misses proposed API: TerminalQuickFixProvider #12522

marcdumais-work opened this issue May 11, 2023 · 0 comments · Fixed by #12532
Assignees
Labels
builtins Issues related to VS Code builtin extensions vscode issues related to VSCode compatibility

Comments

@marcdumais-work
Copy link
Contributor

Bug Description:

Testing locally-built vscode built-in extensions 1.77.0, I have encountered an issue with the activation of vscode.npm.

Key part of the exception:

023-05-11T18:59:26.965Z root ERROR [hosted-plugin: 2800503] Activating extension 'NPM support for VS Code (built-in)' failed: TypeError: i.window.registerTerminalQuickFixProvider is not a function

It looks like it's using new proposed API: TerminalQuickFixProvider

Steps to Reproduce:

Use this locally built extension in your Theia example app:
npm-1.77.0.zip

Additional Information

Full exception:

023-05-11T18:59:26.965Z root ERROR [hosted-plugin: 2800503] Activating extension 'NPM support for VS Code (built-in)' failed: TypeError: i.window.registerTerminalQuickFixProvider is not a function
    at e.activate (/tmp/vscode-unpacked/npm-1.77.0.vsix/extension/dist/npmMain.js:2:326746)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async PluginManagerExtImpl.startPlugin (/home/lmcmcds/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:310:34)
    at async /home/lmcmcds/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:219:21
    at async PluginManagerExtImpl.$activatePlugin (/home/lmcmcds/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:271:13)
    at async Promise.all (index 12)
    at async PluginManagerExtImpl.activateBySingleEvent (/home/lmcmcds/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:266:9)
    at async PluginManagerExtImpl.$activateByEvent (/home/lmcmcds/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:250:13)
    at async PluginManagerExtImpl.$start (/home/lmcmcds/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:148:9)
    at async RpcProtocol.handleRequest (/home/lmcmcds/theia/packages/core/lib/common/message-rpc/rpc-protocol.js:167:28)
  • Operating System:
  • Theia Version:
@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility builtins Issues related to VS Code builtin extensions labels May 11, 2023
@vince-fugnitto vince-fugnitto self-assigned this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants