Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secondary window in browser close/reopen has odd behaviour #12907

Open
Tracked by #13192
MatthewKhouzam opened this issue Sep 14, 2023 · 3 comments
Open
Tracked by #13192

Secondary window in browser close/reopen has odd behaviour #12907

MatthewKhouzam opened this issue Sep 14, 2023 · 3 comments
Labels
secondary-window issues related to multi or secondary window support

Comments

@MatthewKhouzam
Copy link

Bug Description:

When one opens a secondary window, then closes it, in the browser, they can then restore the last closed window. This is typically by pressing the ctrl-shift-n combo or something equivalent in other OSes will re-open a closed window. That window is now "useless".

Steps to Reproduce:

  1. Open a terminal from theia browser.
  2. Make it go to a secondary window
  3. close that window
  4. re-open it with ctrl-shift-n

See video for an illustration.

secondary.mp4

Additional Information

  • Operating System: Linux
  • Theia Version: 1.38 and 1.41
@vince-fugnitto vince-fugnitto added the secondary-window issues related to multi or secondary window support label Sep 15, 2023
@MatthewKhouzam
Copy link
Author

Should it be part of #12693

@JonasHelming
Copy link
Contributor

I was not aware of this key combination! good catch!

@JonasHelming JonasHelming mentioned this issue Dec 19, 2023
58 tasks
@tsmaeder
Copy link
Contributor

Our approach is to copy the html nodes from the main to the secondary window. We lose all that content when we close the window. I don't see a way to recover the secondary window content, so maybe the "solution" is to disable the reopening of the windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
secondary-window issues related to multi or secondary window support
Projects
None yet
Development

No branches or pull requests

4 participants