Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command theia clean doesn't remove gen-webpack.node.config.js #12974

Closed
ozfox opened this issue Oct 3, 2023 · 0 comments · Fixed by #12975
Closed

Command theia clean doesn't remove gen-webpack.node.config.js #12974

ozfox opened this issue Oct 3, 2023 · 0 comments · Fixed by #12975
Labels
theia-cli issues related to the theia-cli

Comments

@ozfox
Copy link
Contributor

ozfox commented Oct 3, 2023

Bug Description:

The theia clean command provided by the cli package does not delete the gen-webpack.node.config.js which was introduced for backend bundling (#12412). This happens because it is not removed by the clean() method of ApplicationPackageManager.

Steps to Reproduce:

  1. cd examples/browser
  2. yarn build
  3. yarn clean && ls -la
  4. Verify that gen-webpack.node.config.js still exists

Additional Information

  • Operating System: Linux
  • Theia Version: master (525b3b1)
@msujew msujew added the theia-cli issues related to the theia-cli label Oct 3, 2023
@ozfox ozfox mentioned this issue Oct 3, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theia-cli issues related to the theia-cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: delete gen-webpack.node.config.js with theia clean command ozfox/theia
2 participants
@msujew @ozfox