Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notebook editor performance #13015

Closed
jonah-iden opened this issue Oct 20, 2023 · 0 comments · Fixed by #14234
Closed

Improve notebook editor performance #13015

jonah-iden opened this issue Oct 20, 2023 · 0 comments · Fixed by #14234
Assignees
Labels
notebook issues related to notebooks performance issues related to performance
Milestone

Comments

@jonah-iden
Copy link
Contributor

Feature Description:

Currently the notebook editor renders a full monaco editor for each code cell. This is quite the performance impact, especialy with large notebooks, containing lots of code cells.
Vscode is fixing this by only rendering cells/editors that are currently visible in the viewport.
Another possible fix could be to only render cheap fake editors and replace them with real ones when a user starts editing.
Maybe even both solutions could be done.

@vince-fugnitto vince-fugnitto added performance issues related to performance notebook issues related to notebooks labels Oct 26, 2023
@jonah-iden jonah-iden self-assigned this Mar 8, 2024
@jfaltermeier jfaltermeier added this to the 1.55.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks performance issues related to performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants