Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[notification] Revise integration of user messages #1360

Closed
AlexTugarev opened this issue Feb 22, 2018 · 7 comments · Fixed by #5830
Closed

[notification] Revise integration of user messages #1360

AlexTugarev opened this issue Feb 22, 2018 · 7 comments · Fixed by #5830
Assignees
Labels
enhancement issues that are enhancements to current functionality - nice to haves notifications issues related to notifications

Comments

@AlexTugarev
Copy link
Contributor

Showing messages at top center can interrupt the user a lot. It should be easier to manage the notifications, and message service clients should have more options.

These points would be useful:

  • timeout option to hide a message if no further action is required (covered by [notification] Auto-dismiss #1081).
  • hide with Esc if no further action is required.
  • MessageService clients should be able to dismiss a message.
  • MessageService clients should be able to update the message, e.g. with progress.
  • statusbar item with a counter for messages in inbox.
  • button to reveal hidden messages in inbox.
  • move container for notifications to a less distracting area.

Some inspiration:

incoming-and-timeout

messages-with-actions

@akosyakov
Copy link
Member

akosyakov commented Jan 16, 2019

Please add notificationFocus and notificationCenterVisible when context keys after implementing it, see definitions here: https://code.visualstudio.com/docs/getstarted/keybindings#_when-clause-contexts

@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves notifications issues related to notifications labels Jan 16, 2019
@AndrienkoAleksandr
Copy link
Contributor

It would be really nice to align notification message ui with VSCode.

@AlexTugarev
Copy link
Contributor Author

@AndrienkoAleksandr, indeed. I’m preparing a PR.

@AlexTugarev
Copy link
Contributor Author

related: #5635

@vince-fugnitto
Copy link
Member

@AlexTugarev do you still plan on working on the PR?

As a POC, I attempted to first move the notifications to the bottom-right, and then update the styling:

Screen Shot 2019-07-12 at 11 51 11 AM

Jul-12-2019 11-55-49

There are a few updates to make:

  • fix the transition (get a fluid animation when opening messages)
  • fix the text wrap
  • make messages smaller
  • fix the buttons (they should look more like vscode and not take up the whole height of a notification
  • allow for additional actions (almost like toolbar items).

@AlexTugarev
Copy link
Contributor Author

Thanks @vince-fugnitto! I started working on this recently and going to push the WIP shortly. Happy to add you as reviewer.

@vince-fugnitto
Copy link
Member

@AlexTugarev I'm excited to see what you come up with :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves notifications issues related to notifications
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants