-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[notification] Revise integration of user messages #1360
Comments
Please add |
It would be really nice to align notification message ui with VSCode. |
@AndrienkoAleksandr, indeed. I’m preparing a PR. |
related: #5635 |
@AlexTugarev do you still plan on working on the PR? As a POC, I attempted to first move the notifications to the bottom-right, and then update the styling: There are a few updates to make:
|
Thanks @vince-fugnitto! I started working on this recently and going to push the WIP shortly. Happy to add you as reviewer. |
@AlexTugarev I'm excited to see what you come up with :) |
Showing messages at top center can interrupt the user a lot. It should be easier to manage the notifications, and message service clients should have more options.
These points would be useful:
timeout
option to hide a message if no further action is required (covered by [notification] Auto-dismiss #1081).Esc
if no further action is required.MessageService
clients should be able to dismiss a message.MessageService
clients should be able to update the message, e.g. with progress.Some inspiration:
The text was updated successfully, but these errors were encountered: