Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] API evolution (public and proposed) and menu declarations between 1.92 and 1.93 (WIP - 1.93 not yet released) #14104

Closed
32 tasks
rschnekenbu opened this issue Sep 3, 2024 · 1 comment
Assignees
Labels
vscode issues related to VSCode compatibility

Comments

@rschnekenbu
Copy link
Contributor

rschnekenbu commented Sep 3, 2024

Sources

  • commit ref for tags

  • command used

    • git difftool -d b1c0a14..b58b045 -- src/vscode-dts/ on vscode repo
    • command: git submodule foreach "grep -irn enabledApiProposals --include=package.json | cut -d ':' -f 1 | xargs jq --raw-output '{filename: input_filename, enabledApiProposals: .enabledApiProposals}'" > ./vscode-builtins-enabled-proposals-1.93.0.txt on vscode-builtin-extensions repo, on commit b58b045
    • git difftool -d b1c0a14..b58b045 -- src/vs/workbench/services/actions/common/menusExtensionPoint.ts on vscode repo

Evaluation

vscode.d.ts

  • TerminalShellIntegration becomes a public API
    • see https://code.visualstudio.com/docs/terminal/shell-integration for the description of the feature.
      Visual Studio Code has the ability to integrate with common shells, allowing the terminal to understand more about what's actually happening inside the shell. This additional information enables some useful features such as [working directory detection](https://code.visualstudio.com/docs/terminal/shell-integration#_current-working-directory-detection) and command detection, [decorations](https://code.visualstudio.com/docs/terminal/shell-integration#_command-decorations-and-the-overview-ruler), and [navigation](https://code.visualstudio.com/docs/terminal/shell-integration#_command-navigation).
    • this API was already available as a proposed API and stubbed as a fix of [VSCode] Support proposed.terminalShellIntegration API #14010
    • Task to be created to move stubs to main and create Implementation task
  • API Description evolution
    • **chore task to update code comments (avoid too many differences with vscode.d.ts to facilitate comparison) **
  • TreeView reveal options fields become readonly
    • task to update API and check implementation is still valid
  • AuthenticationSessionAccountInformation and multiple accounts support additions
  • TestMessageStackFrame addition
    • A stack frame found in the TestMessage.stackTrace
    • create task to add such feature

Proposed API evolutions

  • vscode.proposed.aiTextSearchProviderNew.d.ts: Updated - builtins impacted: Not used by builtins.
  • vscode.proposed.authGetSessions.d.ts: Deleted - builtins impacted: Not used by builtins.
  • vscode.proposed.chatParticipantAdditions.d.ts: Updated - builtins impacted: Not used by builtins.
  • vscode.proposed.chatParticipantPrivate.d.ts: Updated - builtins impacted: Not used by builtins.
  • vscode.proposed.chatProvider.d.ts: Updated - builtins impacted: Not used by builtins.
  • vscode.proposed.chatVariableResolver.d.ts: Updated - builtins impacted: Not used by builtins.
  • vscode.proposed.contribChatParticipantDetection.d.ts: Renamed - builtins impacted: Not used by builtins.
  • vscode.proposed.contribDebugCreateConfiguration.d.ts: New - builtins impacted: Not used by builtins.
  • vscode.proposed.contribSourceControlHistoryItemChangesMenu.d.ts: Deleted - builtins impacted: Git.
  • vscode.proposed.contribSourceControlHistoryItemGroupMenu.d.ts: Deleted - builtins impacted: Git.
  • vscode.proposed.contribSourceControlHistoryItemMenu.d.ts: Updated - builtins impacted: Git.
  • vscode.proposed.contribSourceControlHistoryTitleMenu.d.ts: New - builtins impacted: Git.
  • vscode.proposed.contribViewContainerTitle.d.ts: New - builtins impacted: Not used by builtins.
  • vscode.proposed.defaultChatParticipant.d.ts: Updated - builtins impacted: Not used by builtins.
  • vscode.proposed.extensionsAny.d.ts: Updated - builtins impacted: extensionsAny.
  • vscode.proposed.fileSearchProviderNew.d.ts: Updated - builtins impacted: Not used by builtins.
  • vscode.proposed.findFiles2New.d.ts: Updated - builtins impacted: Not used by builtins.
  • vscode.proposed.findTextInFilesNew.d.ts: Updated - builtins impacted: Not used by builtins.
  • vscode.proposed.interactive.d.ts: Updated - builtins impacted: Not used by builtins.
  • vscode.proposed.lmTools.d.ts: Updated - builtins impacted: Not used by builtins.
  • vscode.proposed.notebookReplDocument.d.ts: New - builtins impacted: Not used by builtins.
  • vscode.proposed.scmHistoryProvider.d.ts: Updated - builtins impacted: Git.
  • vscode.proposed.terminalShellIntegration.d.ts: Deleted, integrated as public API - builtins impacted: Not used by builtins.
  • vscode.proposed.testMessageStackTrace.d.ts: Deleted, integrated as public API - builtins impacted: Not used by builtins.
  • vscode.proposed.testObserver.d.ts: Updated - builtins impacted: vscode-selfhost-testObserver, can be ignored.
  • vscode.proposed.textSearchCompleteNew.d.ts: Updated - builtins impacted: Not used by builtins.
  • vscode.proposed.textSearchProviderNew.d.ts: Updated - builtins impacted: Not used by builtins.

Details on scmHistoryProvider evolutions:

  • provideHistoryItems: Updated - The method signature was modified by removing the historyItemGroupId parameter from provideHistoryItems and provideHistoryItems2, consolidating them into a single method provideHistoryItems(options: SourceControlHistoryOptions, token: CancellationToken): ProviderResult<SourceControlHistoryItem[]>.
  • resolveHistoryItemGroupCommonAncestor: Updated - The two separate methods resolveHistoryItemGroupCommonAncestor and resolveHistoryItemGroupCommonAncestor2 were consolidated into one method resolveHistoryItemGroupCommonAncestor(historyItemGroupIds: string[], token: CancellationToken): ProviderResult<string>.
  • SourceControlHistoryOptions: Updated - Added a new property skip?: number to the SourceControlHistoryOptions interface.
  • SourceControlHistoryItem: Updated - Added a new optional property displayId?: string to the SourceControlHistoryItem interface.

Details on extensionsAny.d.ts:

  • getExtension: Updated - Added a new overload for the getExtension function with the signature getExtension<T = any>(extensionId: string, includeDifferentExtensionHosts: true): Extension<T | undefined> | undefined.

Menu evolutions

To be finalized later

@rschnekenbu rschnekenbu self-assigned this Sep 3, 2024
@rschnekenbu rschnekenbu added the vscode issues related to VSCode compatibility label Sep 3, 2024
@rschnekenbu rschnekenbu changed the title [[vscode] proposed API evolution and menu declarations between 1.92 and 1.93 (WIP - 1.93 not yet released) [vscode] proposed API evolution and menu declarations between 1.92 and 1.93 (WIP - 1.93 not yet released) Sep 3, 2024
@rschnekenbu rschnekenbu changed the title [vscode] proposed API evolution and menu declarations between 1.92 and 1.93 (WIP - 1.93 not yet released) [vscode] API evolution (public and proposed) and menu declarations between 1.92 and 1.93 (WIP - 1.93 not yet released) Sep 3, 2024
@rschnekenbu
Copy link
Contributor Author

closed as documentation task. Menu evolutions done on #14106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

1 participant