-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[electron] Connection to a remote backend #2056
Comments
What's the current state of this issue? |
I did realize a prototype, but we decided to not go forward with it at the moment. The main issue is security: loading remote content inside an electron browser window is not recommended when using electron's api + node integration. On the other hand, the electron frontend code doesn't work really well out of the box without electron + node apis, and some monkey patching needs to be made so that some components don't try to use Closed PR: #2340 TL;DR: Can be done, but it feels sketchy to me for now. A lot of care needs to be taken in regards to security when doing this. |
We have SSH remot support now, can we close this? @paul-marechal |
@JonasHelming Yes, I'll close this. For everyone still interested in this issue. Please see #12390. |
@JonasHelming yes this can be closed thanks to the amazing work by @msujew on the SSH support :) |
Goal
Being able to use the Theia desktop version running in electron to connect to a remote backend.
Approaches
While (2) was prototyped, we could foresee problems with mismatching Theia's versions: the JSON-RPC protocol transfered over the Websocket might break because of some changes made between the versions.
On the other hand (1) makes the browser dependent on Electron. But part of the work will be to maybe make this remote connection feature an extension that could be supported or not based on the needs of both the host and the client.
To be done
The text was updated successfully, but these errors were encountered: