Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plug-in] create a file system watcher #3163

Closed
akurinnoy opened this issue Oct 12, 2018 · 1 comment
Closed

[plug-in] create a file system watcher #3163

akurinnoy opened this issue Oct 12, 2018 · 1 comment
Labels
plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team

Comments

@akurinnoy
Copy link
Contributor

akurinnoy commented Oct 12, 2018

Documentation
Need for XML LS
Language servers may need to know changes on other files that are not only editor buffers: node_modules folder, yarn.lock, maven target folder ....

@akurinnoy akurinnoy added plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team labels Oct 12, 2018
@akurinnoy akurinnoy changed the title [plug-in] implement FileSystemWatcher [plug-in] create a file system watcher Oct 12, 2018
@mmorhun
Copy link
Contributor

mmorhun commented Nov 12, 2018

To avoid unneeded traffic between plugin and Theia it seems wise to filter file system events on Theia side and sent a message over network if a match found.
However, in out current model all messages from plugin are sent to Theia client side. In case of frontend plugin it is ok, but in case of backend plugin, when interaction with Theia server side only needed, we have traffic "loop". This is more general problem than this issue itself and is out of this issue scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team
Projects
None yet
Development

No branches or pull requests

2 participants