Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plug-in] Progress bar doesn't work correctly with plugins #4027

Closed
svor opened this issue Jan 11, 2019 · 3 comments · Fixed by #4156
Closed

[plug-in] Progress bar doesn't work correctly with plugins #4027

svor opened this issue Jan 11, 2019 · 3 comments · Fixed by #4156
Labels
plug-in system issues related to the plug-in system

Comments

@svor
Copy link
Contributor

svor commented Jan 11, 2019

Status bar has many instances of progress bar when vscode-java extension was ran as a plugin:
screenshot-localhost-3000-2019 01 11-14-29-25

And many console errors like:

root ERROR Warning: Encountered two children with the same key, `Building workspace - 0%null1null`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
@akosyakov
Copy link
Member

@svor which version of java extension do you use? with 0.37.0 i cannot get it running at all:

root ERROR [hosted-plugin: 21574] (node:21574) UnhandledPromiseRejectionWarning: TypeError: Path must be a string. Received undefined
    at assertPath (path.js:28:11)
    at Object.resolve (path.js:1171:7)
    at Object.t.collectionJavaExtensions (/tmp/vscode-unpacked/redhat.java-0.37.0.vsix/extension/dist/extension.js:1:192841)
    at Promise (/tmp/vscode-unpacked/redhat.java-0.37.0.vsix/extension/dist/extension.js:1:110531)
    at new WrappedPromise (/tmp/vscode-unpacked/vscjava.vscode-java-debug-0.16.0.vsix/extension/node_modules/async-listener/es6-wrapped-promise.js:13:18)
    at a.window.withProgress.n (/tmp/vscode-unpacked/redhat.java-0.37.0.vsix/extension/dist/extension.js:1:109673)
    at StatusBarExtImpl.<anonymous> (/workspace/theia/packages/plugin-ext/lib/plugin/statusBar.js:73:35)
    at step (/workspace/theia/packages/plugin-ext/lib/plugin/statusBar.js:47:23)
    at Object.next (/workspace/theia/packages/plugin-ext/lib/plugin/statusBar.js:28:53)
    at fulfilled (/workspace/theia/packages/plugin-ext/lib/plugin/statusBar.js:19:58)

@svor
Copy link
Contributor Author

svor commented Jan 23, 2019

@akosyakov I've used 0.36.0

@akosyakov
Copy link
Member

ok, anyway, from code is clear that a new status bar entry is created each time when text is set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants