Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plug-in] window.onDidChangeActiveTextEditor is not fired #4218

Closed
vitaliy-guliy opened this issue Feb 1, 2019 · 3 comments
Closed

[plug-in] window.onDidChangeActiveTextEditor is not fired #4218

vitaliy-guliy opened this issue Feb 1, 2019 · 3 comments
Assignees
@mmorhun
Labels
bug bugs found in the application plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility

Comments

@vitaliy-guliy
Copy link
Contributor

Sometimes when restoring the Theia layout after restoring opened files the theia.window.onDidChangeActiveTextEditor occasionally is not sent.
Plugin cannot handle active text editor properly.
@vitaliy-guliy vitaliy-guliy added bug bugs found in the application plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team labels Feb 1, 2019
@evidolob evidolob mentioned this issue Feb 1, 2019
Closed
43 tasks
@tsmaeder tsmaeder added the vscode issues related to VSCode compatibility label Feb 6, 2019
@evidolob evidolob mentioned this issue Feb 20, 2019
Closed
40 tasks
@mmorhun mmorhun self-assigned this Mar 1, 2019
@mmorhun
Copy link
Contributor

mmorhun commented Mar 4, 2019

Cannot reproduce the described problem.
But during testing found that there is some focus related differences with VSCode: Theia triggers a new onDidChangeActiveTextEditor event when focus was taken and then returned back.

@mmorhun mmorhun mentioned this issue Mar 7, 2019
Merged
@mmorhun
Copy link
Contributor

mmorhun commented Mar 11, 2019

Also VSCode fires the onDidChangeActiveTextEditor with undefined after an editor tab closing.

@mmorhun mmorhun closed this as completed Mar 11, 2019
@mmorhun
Copy link
Contributor

mmorhun commented Mar 11, 2019

Mentioned above incompatibilities are fixed in the PR above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmorhun mmorhun

Labels
bug bugs found in the application plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vitaliy-guliy @tsmaeder @mmorhun