Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin code gets loaded outside of plugin host process #4271

Open
akosyakov opened this issue Feb 7, 2019 · 2 comments
Open

plugin code gets loaded outside of plugin host process #4271

akosyakov opened this issue Feb 7, 2019 · 2 comments
Assignees
Labels
bug bugs found in the application critical critical bugs / problems performance issues related to performance plug-in system issues related to the plug-in system

Comments

@akosyakov
Copy link
Member

Plugin code gets bundled by webpack and loaded by node server process.

Plugin code loaded in the browser main process:
screen shot 2019-02-07 at 08 03 13

DialogsExtImpl bundled by webpack for the main browser process:
screen shot 2019-02-07 at 08 04 42

@akosyakov akosyakov added bug bugs found in the application performance issues related to performance plug-in system issues related to the plug-in system labels Feb 7, 2019
@akosyakov akosyakov added the critical critical bugs / problems label Mar 20, 2019
@akosyakov
Copy link
Member Author

It also makes the bundling with webpack slower since it needs to load more unnecessary files. We have to sort it out.

@akosyakov
Copy link
Member Author

@evidolob I think you are almost nailed it! I can see only 3 files are loaded:
Screen Shot 2019-08-18 at 15 11 10

If these files are reused in main process, maybe we should move them to common.

It would be good to have #5873 that it does not leak again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application critical critical bugs / problems performance issues related to performance plug-in system issues related to the plug-in system
Projects
None yet
Development

No branches or pull requests

2 participants