[Plug-in] workspace.findFiles not working as expected

[invincibleJai]

Find files across all workspace folders in the workspace. https://code.visualstudio.com/api/references/vscode-api#workspace.findFiles

vscode.workspace.findFiles(include: GlobPattern, exclude?: GlobPattern | null, maxResults?: number, token?: CancellationToken): Thenable<Uri[]>

sample - findFiles('package.json', '**/node_modules/**', 10)

It's listing all occurrences of package.json even one inside node_modules which should be excluded and even this parameter count has no effect.

Currently, even relative pattern is not working as expected i.e

const relativePattern = new vscode.RelativePattern(
            workspaceFolder,
            '{pom.xml,**/package.json,requirements.txt}'
          );
vscode.workspace.findFiles(relativePattern, '**/node_modules')

it returns empty []

[slemeur]

@evidolob : Is that something your team can take care off?

[invincibleJai]

Thanks @slemeur . I see it's been already implemented #3128 by @vparfonov but am experiencing above.

[invincibleJai]

Guys, any update on this thread. Thanks!!

[vparfonov]

@invincibleJai I will take a look

[invincibleJai]

@vparfonov thanks and for testing
am using image theiaide/theia-full:next

https://github.com/redhat-developer/vscode-openshift-tools/wiki/Testing

Will the changes be available there?

[vparfonov]

@invincibleJai Yes, if you run in with "next" it should be available

[invincibleJai]

thanks @vparfonov, I tried on next and still i get same experience as in issue.

[vparfonov]

@invincibleJai Can, you, please build it from source and check again. Also can you share plugin what you try? Thanks

[invincibleJai]

@vparfonov am trying on https://marketplace.visualstudio.com/items?itemName=redhat.fabric8-analytics

Can you pls help with some doc to build from src, i tried some time back but couldn't

PS: it's using preview-html so am making changes to files in /tmp/vscode-unpacked/vscode_extension_redhat_fabric8_analytics.vsix/extension/ for debugging testing extension

[invincibleJai]

@vparfonov need your help, have tried with latest theia-full:next and earlier when I filed the issue basic search without glob used to work as in

vscode.workspace.findFiles('target/npmlist.json')

but now even for this am getting an empty list. It'll be really nice if you can verify once.

[invincibleJai]

@vparfonov it's working even with vscode.RelativePattern, one thing why i got confused initially is if we pass vscode.workspace.findFiles('target/npmlist.json') it returns empty list and when we change vscode.workspace.findFiles('**/target/npmlist.json') it's able to search.