Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The intelephense PHP extension requires VS Code support to be at least of v.1.31.0 #4578

Closed
vrubezhny opened this issue Mar 15, 2019 · 3 comments

Comments

@vrubezhny
Copy link
Contributor

Description

It is impossible to install intelephense extension as Theia extension plugin because it requires VS Code v. >= 1.31.0, while we declare it to be 1.27.2 in plugin-ext-vscode. (I'm not sure on all the consequences, but the intelephenseextension was satisfied when I applied the following simple fix that just changes the declared VS Code version to be1.31.0`:

$ git diff packages/plugin-ext-vscode/src/node/plugin-vscode-init.ts
diff --git a/packages/plugin-ext-vscode/src/node/plugin-vscode-init.ts b/packages/plugin-ext-vscode/src/node/plugin-vscode-init.ts
index 1e017b9f..55381bf9 100644
--- a/packages/plugin-ext-vscode/src/node/plugin-vscode-init.ts
+++ b/packages/plugin-ext-vscode/src/node/plugin-vscode-init.ts
@@ -72,7 +72,7 @@ export const doInitialization: BackendInitializationFn = (apiFactory: PluginAPIF
     };
 
     // override the version for vscode to be a VSCode version
-    (<any>vscode).version = '1.27.2';
+    (<any>vscode).version = '1.31.0';

Reference issues:
eclipse-che/che#12796
eclipse-che/che#12797

@tsmaeder
Copy link
Contributor

See also #4124

@tsmaeder
Copy link
Contributor

tsmaeder commented Mar 19, 2019

@vrubezhny is there an older version of the plugin that would work with 1.27.2? If yes, what would we be missing compared to the latest version?

@vrubezhny
Copy link
Contributor Author

Closing the issue as vscode supported version is updated by resolving #4124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants