Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[electron example] Add plugin support #4802

Closed
ciampolo opened this issue Apr 3, 2019 · 4 comments · Fixed by #4842
Closed

[electron example] Add plugin support #4802

ciampolo opened this issue Apr 3, 2019 · 4 comments · Fixed by #4842
Labels
bug bugs found in the application electron issues related to the electron target help wanted issues meant to be picked up, require help

Comments

@ciampolo
Copy link

ciampolo commented Apr 3, 2019

Description

So I have placed the vscode chrome debug extension inside the theia git root folder/plugins. When I run the theia electron variant there isn't any plugin view at all and the extension isn't registered (electron theia says there is no "Chrome" debug type). I checked the stdout of the yarn run start command and the logs of the devtools, nothing about plugins or the chrome debugger. This also happens without any plugins at all. When I use the Browser variant everything works flawlessly.

OS: Linux
Theia: Latest upstream and 0.5.0

Am I missing something obvious or is this just a bug?

@marcdumais-work
Copy link
Contributor

The plugin extensions are not currently part of the Electron example application. I do not know if it was just missed or if it's because there's an issue.

Untested patch where they are added here

@marcdumais-work marcdumais-work added electron issues related to the electron target enhancement issues that are enhancements to current functionality - nice to haves labels Apr 4, 2019
@marcdumais-work marcdumais-work changed the title No plugins in electron variant but works fine in browser [electron example] Add plugin support Apr 4, 2019
@ciampolo
Copy link
Author

ciampolo commented Apr 4, 2019

While the plugin extension is loaded correctly now it doesn't actually load the vscode extensions.

root ERROR Cannot find a service for the path: /services/plugin-ext
root ERROR Cannot find a service for the path: /services/plugin-paths

Your reverts #3737 so it should work but apparently there is other code left to modify.

@benoitf
Copy link
Contributor

benoitf commented Apr 4, 2019

FYI it was disabled by #3723

@akosyakov
Copy link
Member

Someone should fix #3651 and #2210 then we can enable it.

@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help and removed enhancement issues that are enhancements to current functionality - nice to haves labels Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application electron issues related to the electron target help wanted issues meant to be picked up, require help
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants