Support C/CPP syntax highlighting by default

[sidazhang]

Description

Currently theia does not support CPP syntax highlighting out of the box.

Is it possible to support CPP syntax highlighting. I am not referring to CPP language server. A simple CPP file syntax highlight is sufficient out of the box

[akosyakov]

We can move https://github.com/theia-ide/theia/blob/master/packages/cpp/src/browser/cpp-grammar-contribution.ts to textmage-grammar extension. PRs are welcomed.

@simark @marechal-p @thegecko hope it is fine with you

[thegecko]

No concerns.

@arekzaluski ?

[vince-fugnitto]

@akosyakov one thing, I'm wondering if it might be wise that the @theia/languages extension explicitly depend on the @theia/textmate-grammars extension.

This would mean that any language extension such as @theia/cpp would not need to depend on @theia/textmate-grammars itself and can benefit from the textmate support. At the moment only the browser and electron example applications currently import the textmate extension. If a user depends on the cpp extension, then he will be sure to have the textmate support as well.

[akosyakov]

We want to get rid of @theia/textmate-grammars eventually, and use vscode built-in extensions for textmate grammars. I don't want to couple it with other extensions because of it.

[vince-fugnitto]

Closed by #5803

[svkr2k]

Hello all,
Kindly confirm, is @theia/textmate-grammars enough for C/C++ syntax highlight and @theia/cpp is not needed anymore ?

[vince-fugnitto]

Kindly confirm, is @theia/textmate-grammars enough for C/C++ syntax highlight and @theia/cpp is not needed anymore ?

@svkr2k the extension @theia/textmate-grammars has been deprecated, syntax-hihglighting for C/C++ is contributed by the vscode builtin extension:

theia/package.json

Line 87 in 66dd2bc

"vscode-builtin-cpp": "http://open-vsx.org/api/vscode/cpp/1.39.1/file/vscode.cpp-1.39.1.vsix",