Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hold all static keyboard layouts in memory #4880

Closed
spoenemann opened this issue Apr 11, 2019 · 1 comment
Closed

Don't hold all static keyboard layouts in memory #4880

spoenemann opened this issue Apr 11, 2019 · 1 comment

Comments

@spoenemann
Copy link
Contributor

Follow-up of #4724: Currently the browser module browser-keyboard-layout-provider loads all available static keyboard layouts. I expect the list of statically available layouts to grow, so at some point the memory footprint might become too large. We should improve this by holding only the active layout in memory. Furthermore, we should avoid to include all layouts in the bundle.js, so we might move them to a backend service.

@spoenemann
Copy link
Contributor Author

spoenemann commented May 7, 2019

This is not possible after #5063 because we need to evaluate all layouts in the browser when the user presses a key.

The total size of all layouts contributed in #5088 is 184 KB (json files).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant