Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label provider should take into account a language matching to the given URI #5016

Open
tolusha opened this issue Apr 26, 2019 · 0 comments
Open
Labels
enhancement issues that are enhancements to current functionality - nice to haves

Comments

@tolusha
Copy link
Contributor

tolusha commented Apr 26, 2019

Description

Label provider [1] should take into account a language matching to the given URI [2] to create an icon, not only a file extension like right now (i.e. UI should reflect mime associations, e.g. explorer should show proper a matching language icon)

[1] https://github.com/theia-ide/theia/blob/master/packages/core/src/browser/label-provider.ts#L27https://github.com/theia-ide/theia/blob/master/packages/filesystem/src/browser/filesystem-frontend-contribution.ts#L161
[2] https://github.com/theia-ide/theia/blob/master/packages/core/src/browser/mime-service.ts#L25

Reference issue

#4581

@tolusha tolusha added the enhancement issues that are enhancements to current functionality - nice to haves label Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves
Projects
None yet
Development

No branches or pull requests

1 participant