Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff Editor Support #503

Closed
svenefftinge opened this issue Sep 12, 2017 · 3 comments
Closed

Diff Editor Support #503

svenefftinge opened this issue Sep 12, 2017 · 3 comments
Assignees
Milestone

Comments

@svenefftinge
Copy link
Contributor

An open handler for diff editors should be registered from within the monaco package.
For the uri, we should use something simple like diff:/caption and the options need to contain the two uris, as well as other options that the monaco diff editor exposes.

@akosyakov
Copy link
Member

other options that the monaco diff editor exposes.

I am not sure about this, e.g. whether editors are read-only or not should be decided internally based on resources.

@svenefftinge
Copy link
Contributor Author

I was thinking of options like renderSideBySide as declared here https://github.com/Microsoft/monaco-editor/blob/4930b6a/monaco.d.ts#L3100

@svenefftinge svenefftinge added this to the Theia 1.0 BETA milestone Sep 21, 2017
@svenefftinge
Copy link
Contributor Author

Fixed with #392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants