Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosted Plugins on Windows not working #5488

Open
FrankMathers opened this issue Jun 17, 2019 · 4 comments
Open

Hosted Plugins on Windows not working #5488

FrankMathers opened this issue Jun 17, 2019 · 4 comments
Labels
OS/Windows issues related to the Windows OS plug-in system issues related to the plug-in system

Comments

@FrankMathers
Copy link

Description

Hosted Plugins on Windows not working

Reproduction Steps

I use yoman to create a simple hello word plugin, when I run hosted plugin, the error "root ERROR Failed to load plugin metadata from" showed.

OS and Theia version:
Windows @theia/example-browser 0.7.0
Diagnostics:
Here is what I found: Packages->plugin-dev->src->node->hosted-plugins-manager.ts
line69 this.checkWatchScript(pluginRootPath) , pluginRootPath = "/c%3A/theia-devtools-plugin/theia-devtools-plugin" which is not right path on windows

@benoitf
Copy link
Contributor

benoitf commented Jun 17, 2019

hello, it's not fixed by #5274 ?

@FrankMathers
Copy link
Author

seems not, I just pulled the latest code, and run, the error is still there.

@vince-fugnitto vince-fugnitto added OS/Windows issues related to the Windows OS plug-in system issues related to the plug-in system labels Oct 29, 2019
@westbury
Copy link
Contributor

westbury commented Jan 9, 2020

This has been fixed by #6316, merged yesterday.

Note that this may not work in Electron for other reasons. With this fix it should work on Windows in the browser.

@tsmaeder
Copy link
Contributor

@westbury if this is confirmed fixed, could you close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Windows issues related to the Windows OS plug-in system issues related to the plug-in system
Projects
None yet
Development

No branches or pull requests

5 participants