Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] window.createQuickPick hide is incomplete #5765

Closed
hacke2 opened this issue Jul 22, 2019 · 0 comments · Fixed by #5766
Closed

[vscode] window.createQuickPick hide is incomplete #5765

hacke2 opened this issue Jul 22, 2019 · 0 comments · Fixed by #5766
Labels
bug bugs found in the application vscode issues related to VSCode compatibility

Comments

@hacke2
Copy link
Contributor

hacke2 commented Jul 22, 2019 •
edited
Loading

Description

See https://code.visualstudio.com/api/references/vscode-api#QuickPick. QuickPick Panel should hide UI when execute hide method. But theia only emit onDidHide event.
@hacke2 hacke2 changed the title [vscode] window.showQuickPick hide is incomplete [vscode] window.createQuickPick hide is incomplete Jul 22, 2019
@hacke2 hacke2 mentioned this issue Jul 22, 2019
Merged
1 task
@akosyakov akosyakov added bug bugs found in the application vscode issues related to VSCode compatibility labels Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [Plugin-API] complete QuickPick hide api hacke2/theia
2 participants
@akosyakov @hacke2