-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure the repository to use separate extensions #59
Comments
Should we also move the main framework to be a sibling rather then the parent of examples (and extensions)? |
We would like to restructure the repository to have sibling npm packages instead of ancestors.
|
Is this still true after LDM ? Can we close this ? |
It is still valid. We should try to decompose theia-core on separate node packages as @svenefftinge described. |
It will be nice to structure in such way that we can open core, extensions, and examples in separate instances of VS code. Since there will be a lot of duplicate dependencies in node_modules and VS code will just go bananas watching them. |
OK I just changed the title to reflect that |
We should reconsider using 'lerna' with dependency hoisting. If we can
|
Related microsoft/TypeScript#16792 |
I managed to end up in *.ts when navigating by putting this into the example's tsconfig: {
...
"baseUrl": "../..",
"paths": {
"theia-core/lib/*": [
"src/*"
],
"*": [
"node_modules/*"
]
}
} We could list all our extensions in a commonly extended tsconfig, so tsc will reslve against the real src. Together with lerna and hoisted dependencies, we should also be able to use symbolic links again. |
Done with #299 |
Because
npm link
only creates a symlink instead of prepublishing and copying content, asnpm install
does, it is recommended to use file dependencies for local development: http://stackoverflow.com/questions/14381898/local-dependency-in-package-jsonIn addition we should make sure that theia
prepublish
script includes other resources as styles and example consumes them fromlib
folder not fromsrc
as now.The text was updated successfully, but these errors were encountered: