[keybinding] wrong keybinding for "Open Preferences" on Mac (Electron): should be Cmd+, not Ctrl+,

[jankeromnes]

On Mac OS (Electron), the keybinding for Settings > Open Preferences is Ctrl + ,.

Instead, it should be Cmd + , because that seems to be the expected keybinding, and it's what VS Code uses for Preferences > Settings.

Notes:

• This probably won't work in browsers, because it conflicts with the browser preferences keybinding, so we'll likely need different keybindings for Electron vs. browsers
• Requested by Arduino here: Use of non-standard macOS short cuts arduino/arduino-pro-ide#16

[svenefftinge]

Could you also take care of the other 'non-native' keybindings, e.g. Cmd + w?
Also I think they should be registered in addition so we don't unnecessarily break electron users that already got familiar with our alternative bindings.

[jankeromnes]

Two excellent ideas, thanks! Will do.

[jankeromnes]

The keybinding is currently hard-coded as Ctrl + ,, regardless of build or OS:

theia/packages/preferences/src/browser/preferences-contribution.ts

Lines 63 to 68 in 2938cd0

	registerKeybindings(keybindings: KeybindingRegistry): void {
	keybindings.registerKeybinding({
	command: CommonCommands.OPEN_PREFERENCES.id,
	keybinding: 'ctrl+,'
	});
	}

I'll take a look at Windows to see if this actually works (in browser and in Electron).

EDIT: Interestingly, Ctrl + , already works as expected on Windows, in browser and in Electron. So this is really just a Mac OS problem (assuming Ctrl + , works on Linux too).

[paul-marechal]

Does replacing the keybinding field by 'ctrlcmd+,' do the trick?

[jankeromnes]

Does replacing the keybinding field by 'ctrlcmd+,' do the trick?

@marechal-p This would almost do the trick, except:

• In Firefox, on Mac, cmd+, is intercepted by the browser (and opens the browser settings instead)
• Some Mac users may already be used to the non-standard ctrl+, shortcut, so it should probably continue to work (even if it's not the default)