Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit opened file size #6615

Closed
shahar-h opened this issue Nov 24, 2019 · 1 comment
Closed

Limit opened file size #6615

shahar-h opened this issue Nov 24, 2019 · 1 comment
Labels
editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves

Comments

@shahar-h
Copy link
Contributor

Description

Currently there is no limit to opened files size. as a result, when opening a huge file it could lead to out of memory issues.

Reproduction Steps

  • Create a file with 1GB random text data via terminal:
    openssl rand -base64 $((1024*1024*1024)) >> large.out
  • Open the file via file explorer.
  • As a result, Theia main process reaches ~1.5GB memory, which could lead to out of memory issues on hosted environments with limited memory.

When trying the same in vscode the following error message appears:
image

@vince-fugnitto
Copy link
Member

@shahar-h thank you for the issue!
At the moment, we already have an existing issue tracking the feature #4731. I will close this one as it's a duplicate.

@vince-fugnitto vince-fugnitto added editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves labels Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves
Projects
None yet
Development

No branches or pull requests

2 participants