eslint: bring back no-implicit-dependencies rule

[paul-marechal]

Description

When I migrated the rules from tslint to eslint, I did not find a no-implicit-dependency rule that could be configured the same way we used to have it on tslint.

Current rules I found to prevent implicit dependencies:

• eslint-plugin-import but the options don't allow us to specify an exhaustive whitelist. (example)
• eslint-plugin-implicit-dependencies but it still doesn't allow us to specify a whitelist.

Old rule used to whitelist the following packages:

@phosphor/algorithm
@phosphor/commands
@phosphor/coreutils
@phosphor/domutils
@phosphor/dragdrop
@phosphor/messaging
@phosphor/properties
@phosphor/signaling
@phosphor/virtualdom
@phosphor/widgets
chai
chai-string
electron
express
fs-extra
inversify
jsdom
lodash.debounce
lodash.throttle
monaco-languageclient
native-keymap
nsfw
react
react-dom
react-virtualized
sinon
temp
typescript
uuid
vscode-jsonrpc
vscode-languageserver
vscode-languageserver-protocol
vscode-languageserver-types
vscode-uri
vscode-ws-jsonrpc
yargs

[paul-marechal]

cc @vince-fugnitto

[paul-marechal]

Worst case scenario we could try to implement our own rule within the repo.

[akosyakov]

If we remove whitelisting how much duplication it causes, can we somehow catch duplicate versions?

[paul-marechal]

We could use peer dependencies, it should mitigate duplication.

[akosyakov]

We could use peer dependencies, it should mitigate duplication.

But it will break the end product if a version does not match with core? I meant to check that we have exactly the same versions across the repo.

Actually @kittaakos built something like that

theia/package.json

Line 48 in d54c2f0

"prepare:hoisting": "theia check:hoisted -s",

. So maybe we just check it more regularly or fail a build if there are different versions in some packages.

[paul-marechal]

Fixing this issue will also fix bundling issues for electron we are having on theia-apps.

@akosyakov I will do like you mentioned and make all implicit dependencies explicit, with a script to make sure the same range is used across the repo.