Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images not loading in jupyter notebooks #7226

Open
hanl00 opened this issue Feb 26, 2020 · 6 comments
Open

Images not loading in jupyter notebooks #7226

hanl00 opened this issue Feb 26, 2020 · 6 comments
Labels
python issues related to the python language / extension vscode issues related to VSCode compatibility

Comments

@hanl00
Copy link

hanl00 commented Feb 26, 2020

Description

Images in jupyter notebooks are not loaded

Reproduction Steps

In theia
Screenshot from 2020-02-26 16-00-07
Screenshot from 2020-02-26 16-00-20
In vscode
Screenshot from 2020-02-26 17-26-49
The files can be found here https://github.com/nicholasl00/theia-switch-workspace

OS and Theia version:
OS: Ubuntu 18.04.4 LTS
Theia: i'm not sure how to find my version. please let me know how
Python plugin: 2020.1.58038

@vince-fugnitto vince-fugnitto added python issues related to the python language / extension vscode issues related to VSCode compatibility labels Feb 26, 2020
@vince-fugnitto
Copy link
Member

@nicholasl00 note, when attempting to open an image file, one should use the Open With > Preview so that the actual image is displayed instead of it's sources.

We have a pull-request which has unfortunately not been completed yet to set the preview as the highest handler of image files (#5230) so that we align in behavior with VS Code.

@davide-sergi
Copy link

@nicholasl00 one question: were you using theia as web or desktop application? because on my side, the notebook view is not totally showed in desktop case. I'm using your same vscode extension .

@vince-fugnitto
Copy link
Member

@nicholasl00 one question: were you using theia as web or desktop application? because on my side, the notebook view is not totally showed in desktop case. I'm using your same vscode extension .

@davide-sergi you might have encountered the following issue (error displaying webviews in electron): #7156

@hanl00
Copy link
Author

hanl00 commented Apr 30, 2020

@nicholasl00 one question: were you using theia as web or desktop application? because on my side, the notebook view is not totally showed in desktop case. I'm using your same vscode extension .

@davide-sergi I'm using theia as a web application. hope that helps

@davide-sergi
Copy link

Thanks @nicholasl00 @vince-fugnitto for quick replies.

@vince-fugnitto this is a big problem for my purpose. I had mistakenly assumed that they both supported it. Developing for convenience only on the web version.
I need to find some kind of workaround. For any suggests, I'm here :)

@marcdumais-work
Copy link
Contributor

I noticed that the MS python extension, made available on open-vsx, is quite a bit bigger vs the one made available in the MS Marketplace. Maybe the result was not correctly web-packed, causing bigger transfers between BE and FE, than necessary?

Playing around it the source repo, I managed to get a .vsix that looks to be the correct size. Perhaps this one would work better?

I added it to the latest release, on my fork, in case you'd like to try it - the easiest is probably to add the URL directly in your app's package.json:
https://github.com/marcdumais-work/vscode-python/releases/tag/2020.11.358366026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python issues related to the python language / extension vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

4 participants