Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markers: improve marker info node sorting (resource) #7318

Closed
vince-fugnitto opened this issue Mar 11, 2020 · 1 comment
Closed

markers: improve marker info node sorting (resource) #7318

vince-fugnitto opened this issue Mar 11, 2020 · 1 comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves markers issues related to problem markers

Comments

@vince-fugnitto
Copy link
Member

Description

At the moment, there is no sorting present for MarkerInfoNodes in the 'problems view'.
Resources are added to view based on when their respective files were opened (in the case of .json) rather than sorted based on the resource's URI.

For example, if I open the file settings.json before b.json from the same directory, b.json is incorrectly displayed as last:

Screen Shot 2020-03-11 at 11 18 44 AM

The reverse will yield the following result:

Screen Shot 2020-03-11 at 11 22 01 AM

This is an error and makes traversing the 'problems view' quite difficult.
For reference, VS Code correctly sorts based on URI no matter which sequence the file(s) were opened:

Screen Shot 2020-03-11 at 11 24 16 AM

There test-case also suggests they sort by resource.

@vince-fugnitto
Copy link
Member Author

Closed thanks to #9691.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves markers issues related to problem markers
Projects
None yet
Development

No branches or pull requests

1 participant