Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybinding collision between 'Toggle Plugins View' and 'Select All Occurrences' #7612

Open
RomanNikitenko opened this issue Apr 19, 2020 · 3 comments
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help keybindings issues related to keybindings plug-in system issues related to the plug-in system

Comments

@RomanNikitenko
Copy link
Contributor

Description

It's impossible to open Plugins view using keybindings when an editor is open.
I think the cause of the problem is keybinding collision between 'Toggle Plugins View' and 'Select All Occurrences'

Reproduction Steps

  1. Try to use ctrl+shift+l to open Plugins view when you don't have open editors: it works.
  2. Open an editor and try to open Plugins view using the corresponding keybinding.
    You can see that Select All Occurrences is executed.

OS and Theia version:
Fedora 31
Theia version: a187f01

@RomanNikitenko RomanNikitenko added bug bugs found in the application keybindings issues related to keybindings labels Apr 19, 2020
@akosyakov
Copy link
Member

Should we change keybinding for plugins?

@akosyakov akosyakov added help wanted issues meant to be picked up, require help plug-in system issues related to the plug-in system labels Apr 20, 2020
@RomanNikitenko
Copy link
Contributor Author

Now I can see another behavior: it always opens Plugins view when I use ctrl+shift+l keybinding.
So, now user can not trigger Select All Occurrences action when an editor is focused - Plugins view is open instead.

@akosyakov
Copy link
Member

We can remove the keybinding for Plugins view. It is not used widely in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help keybindings issues related to keybindings plug-in system issues related to the plug-in system
Projects
None yet
Development

No branches or pull requests

2 participants