Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace usages of Keybinding.context with Keybinding.when #7849

Closed
akosyakov opened this issue May 20, 2020 · 3 comments
Closed

replace usages of Keybinding.context with Keybinding.when #7849

akosyakov opened this issue May 20, 2020 · 3 comments
Labels
help wanted issues meant to be picked up, require help keybindings issues related to keybindings quality issues related to code and application quality

Comments

@akosyakov
Copy link
Member

Command.context is deprecated and should be remove in future releases
@akosyakov akosyakov added quality issues related to code and application quality commands issues related to application commands help wanted issues meant to be picked up, require help keybindings issues related to keybindings and removed commands issues related to application commands labels May 20, 2020
@akosyakov akosyakov changed the title replace usages of Command.context with Command.when replace usages of Keybinding.context with Keybinding.when May 20, 2020
@kittaakos
Copy link
Contributor

Command.context is deprecated and should be remove in future releases

Let's remove it once we have some sort of documentation about the transition. Thanks!

@akosyakov
Copy link
Member Author

It should be the part of the task to update CHANGELOG.md explaining what should be used instead and how.

@kittaakos kittaakos mentioned this issue May 26, 2020
Merged
1 task
@vince-fugnitto vince-fugnitto mentioned this issue Jun 28, 2023
Closed
@tsmaeder
Copy link
Contributor

Closing in favor of #12657, which contains more info about motivation. Good catch, @vince-fugnitto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted issues meant to be picked up, require help keybindings issues related to keybindings quality issues related to code and application quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kittaakos @akosyakov @tsmaeder