Modal notification does not render newlines or have a max-width

[tetchel]

Bug Description:

A modal dialog shown using

vscode.window.showWarningMessage(<msg>, { modal: true })

does not render newlines or have a max-width, which makes long messages stretch the dialog the width of the viewport, which looks weird.

Steps to Reproduce:

Have a modal notification with a long message in it and newlines. In VS Code, the text is wrapped, and newlines are rendered.

But in Theia, the newlines are ignored, and the dialog stretches.

Additional Information

• Operating System: all
• Theia Version: 0.15.0

[vince-fugnitto]

@tetchel would you like to prepare a pull-request to address the issue?

[kittaakos]

Known limitation: #7283 (comment)?

[vince-fugnitto]

Known limitation: #7283 (comment)?

The limitation is only for notification messages (toasts) similarly to vscode.
For notifications which are present in a dialog window, the explicit newlines are respected:

The issue I believe is that we likely do not handle template literal newlines and we don't have a max-width to the dialog to look consistent.

[kittaakos]

The limitation is only for notification messages (toasts) similarly to vscode.

Yes, that was clear. vscode.window.showWarningMessage uses the notification messages.

[vince-fugnitto]

The limitation is only for notification messages (toasts) similarly to vscode.

Yes, that was clear. vscode.window.showWarningMessage uses the notification messages.

Unless we use modal: true as an option (then it is rendered as a modal and not a toast):

vscode.window.showWarningMessage(<msg>, { modal: true })

[kittaakos]

Unless we use modal: true as an option (then it is rendered as a modal and not a toast):

I see your point. Is it a missing feature? So when modal is true, we should open a Dialog instead of a notification popup?

[vince-fugnitto]

Unless we use modal: true as an option (then it is rendered as a modal and not a toast):

I see your point. Is it a missing feature? So when modal is true, we should open a Dialog instead of a notification popup?

The custom dialog that I sent a screenshot of is the modal implementation that we currently have (we do not use the browser modal). The issue is that we probably do not support string literals with newlines (which is what the codewind extension uses), and we likely do not have any max-width to force wrapping of the textual content.