Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing commands prevents rendering a menu #827

Closed
akosyakov opened this issue Nov 13, 2017 · 3 comments
Closed

Missing commands prevents rendering a menu #827

akosyakov opened this issue Nov 13, 2017 · 3 comments
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help shell issues related to the core shell

Comments

@akosyakov
Copy link
Member

I've got the following error:

Uncaught (in promise) Error: A command with id 'core.save' does not exist.
    at ActionMenuNode.get [as label] (http://localhost:3000/bundle.js:36121:23)
    at ActionMenuNode.get [as sortString] (http://localhost:3000/bundle.js:36137:46)
    at http://localhost:3000/bundle.js:36066:20
    at Array.sort (native)
    at CompositeMenuNode.addNode (http://localhost:3000/bundle.js:36065:24)
    at MenuModelRegistry.registerMenuAction (http://localhost:3000/bundle.js:35981:23)
    at CommonFrontendContribution.registerMenus (http://localhost:3000/bundle.js:23101:18)
    at MenuModelRegistry.onStart (http://localhost:3000/bundle.js:35966:25)
    at FrontendApplication.<anonymous> (http://localhost:3000/bundle.js:18058:36)
    at step (http://localhost:3000/bundle.js:17937:23)

We should handle it gracefully, report to a user and ensure that a menu item either not rendered or rendered as disabled.

@akosyakov akosyakov added shell issues related to the core shell bug bugs found in the application help wanted issues meant to be picked up, require help labels Nov 13, 2017
@theBadT
Copy link
Contributor

theBadT commented Mar 20, 2019

@akosyakov Hi, I'd like to have a look into the issue. Is there any more input available? like a scenario for reproduction?

@akosyakov
Copy link
Member Author

akosyakov commented Mar 21, 2019

You can build an extension which registers a menu via MenuContribution, but contributes an underlying command dynamically, for instance via calling another command.

@vince-fugnitto
Copy link
Member

Closed thanks to #5894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help shell issues related to the core shell
Projects
None yet
Development

No branches or pull requests

3 participants