-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environmentVariableCollection to PluginContext #8405
Comments
@vinokurig Could you elaborate which extensions are using it please? |
The built-in vscode Git extension uses it since 1.45.0: https://github.com/microsoft/vscode/blob/d69a79b73808559a91206d73d7717ff5f798f23c/extensions/git/src/terminal.ts#L20-L24 |
@vinokurig are you working on this issue any time soon or we can try? |
@amiramw I am working om it right now. I am going to open a PR this week |
@vinokurig That's great. Do you know if this the only gap in order to support builtin git? |
It is already possible to use the vscode git version 1.44.2. This is needed to use later versions. |
Recently
environmentVariableCollection
was added to vscode plugin API by microsoft/vscode@af3c79e.Feature Description:
Need to align theia's
PluginContext
withExtensionContext
from vscode. It is needed to use the latest vscode git extension: https://github.com/microsoft/vscode/blob/5185d7e6f8a1ca1c5e03f21d62f0a113d234a95d/extensions/git/src/terminal.ts#L20The text was updated successfully, but these errors were encountered: