Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] widget background is transparent making brand logo visible #8444

Closed
GNSubrahmanyam opened this issue Aug 30, 2020 · 2 comments · Fixed by #8448
Closed

[Bug] widget background is transparent making brand logo visible #8444

GNSubrahmanyam opened this issue Aug 30, 2020 · 2 comments · Fixed by #8448
Labels
ui/ux issues related to user interface / user experience

Comments

@GNSubrahmanyam
Copy link

Bug Description:

widget background is transparent. Brand logo is visble

I added a branding extension similar to https://github.com/vince-fugnitto/theia-cpp-branding.

It works fine to the extent the logo is added to the empty panel.

But when I open the preview of a markdown file, the rendered output panel has a transparent background causing the logo to be visible and conflict with the rendered preview.

Steps to Reproduce:

  1. Add brand logo
#theia-main-content-panel {
    background-image: var(--theia-brand-logo);
    background-position: center center;
    background-repeat: no-repeat;
    background-size: var(--theia-brand-logo-size);
}
  1. Go to preferences or view any preview
  2. Brand logo is visible

image
image

Additional Information

  • Operating System:
  • Theia Version: 1.5.0

cc: @vince-fugnitto

@vince-fugnitto
Copy link
Member

@GNSubrahmanyam thank you for opening an issue, it is likely a regression is recent releases. Feel free to provide a pull-request to resolve the issue (likely similar to the previous pull-request).

@GNSubrahmanyam
Copy link
Author

Welcome @vince-fugnitto, It's been only two days I am working with Thiea IDE. We are integrating Theia IDE into our product.
I will try my best to fix this issue. theia-settings-container class for preference panel and theia-preview-widget class for preview panel am i right? As i can see this property --theia-layout-color0 is deprecated

@vince-fugnitto vince-fugnitto added the ui/ux issues related to user interface / user experience label Aug 31, 2020
@vince-fugnitto vince-fugnitto changed the title [Bug] widget background is transparent. Brand logo is visble [Bug] widget background is transparent making brand logo visible Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants